1180027 - [Contacts] There will be a blank area at the top of the WiFi settings if the user enables WiFi while trying to sign into an email account to import contacts

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Adam Alldredge [:AdamA][Inactive]]

Attachment: logcat

Description:
If the user tries to sign into a gmail or outlook account to sync contacts and enables wifi through the utility tray to to open the wifi settings there will be a blank areas between the status bar and the top of the wifi settings. 

Repro Steps:
1) Update a Aries to 20150702210513
2) Make sure WiFi is disabled and data is enabled
3) Open contacts
4) Click on the gear icon to open settings
5) Select to import contacts from a Gmail or outlook account
6) While the email sign in screen is active open the utility tray and enable wifi
7) Observe top of wifi settings screen as it opens

Actual:
There is a blank space at the top of wifi settings

Expected:
it is expected that there is no blank area at the top of the wifi settings

Environmental Variables:
Device: Aries 2.5 (Full Flash)
Build ID: 20150702210513
Gaia: 722028715a56a03f327e2e70f2c32dcb6d819d4c
Gecko: 2f25351c5b05
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 42.0a1 (2.5)
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Repro frequency: 10/10
See attached: screenshot, logcat

Comment 1

[Adam Alldredge [:AdamA][Inactive]]

This issue DOES occur on Flame 2.5 and Flame 2.2.

Environmental Variables:
Device: Flame 2.5 (Full Flash)
BuildID: 20150702010204
Gaia: b901c8b7be2119f4df42781aac1401ed12765460
Gecko: f5e3bacfb60e
Gonk: a4f6f31d1fe213ac935ca8ede7d05e47324101a4
Version: 42.0a1 (2.5) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:42.0) Gecko/42.0 Firefox/42.0

Device: Flame 2.2 (Full Flash)
BuildID: 20150702002503
Gaia: bd386f346eb1591fddbc84bf034b22700e7e2a58
Gecko: f16c1125b9d6
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Result:
There is a blank space at the top of wifi settings
---------------------------------------------
This issue DOES NOT occur on Flame 2.1.

Environmental Variables:
Device: Flame 2.1 (Full Flash)
BuildID: 20150702001208
Gaia: 7080a7c28b0242f81d689d2339dfa1177e23f48f
Gecko: c201e76c63d1
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 34.0 (2.1) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:34.0) Gecko/34.0 Firefox/34.0

Result:
There is not a blank space at the top of wifi settings

Comment 2

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Spark blank space

Comment 3

[Adam Alldredge [:AdamA][Inactive]]

Attachment: Flame blank space

Comment 4

[Johan Lorenzo [:jlorenzo]]

[Blocking Requested - why for this release]: Visible regression.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comms triage: Regression.

Comment 6

[Peter Bylenga [:PBylenga]]

Requesting a window.

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Bug 1007600 seems to have caused this issue.  Naoki, Arthur is marked as inactive so do you know who this should go to now?

B2g-inbound Regression Window

Last Working 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141020205719
Gaia: e09e1734ad523cf63351a28f6f84454319349fbe
Gecko: 4da1f6a151d6
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

First Broken 
Environmental Variables:
Device: Flame 2.2
BuildID: 20141020214218
Gaia: ba10744d64411a8a12ae68f7cf1ec3e3ac897d21
Gecko: bcc5df613d83
Version: 36.0a1 (2.2) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:36.0) Gecko/36.0 Firefox/36.0

Last Working gaia / First Broken gecko - Issue does NOT occur
Gaia: e09e1734ad523cf63351a28f6f84454319349fbe
Gecko: bcc5df613d83

First Broken gaia / Last Working gecko - Issue DOES occur
Gaia: ba10744d64411a8a12ae68f7cf1ec3e3ac897d21
Gecko: 4da1f6a151d6

Gaia Pushlog: https://github.com/mozilla-b2g/gaia/compare/e09e1734ad523cf63351a28f6f84454319349fbe...ba10744d64411a8a12ae68f7cf1ec3e3ac897d21

Comment 9

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Henry, can you take a look or redirect to an appropriate person?  Otherwise please NI me back so I can take a look at backing this change out.

Comment 10

[Henry Chang [:hchang]]

It's supposed be a gaia settings app bug and no idea who is the owner now :(

Comment 11

[Francisco Jordano [:arcturus] [:francisco]]

Moving to settings, but have the feeling that could be a window management issue.

Comment 12

[Ken Chang[:kenkai]]

Fred, Please look into this bug? Thanks.

Comment 13

[[e-mail]]

@adam I can't reproduce on latest foxfooding aries and nightly flame, neither with nor without 3G connection. Could you help confirm the issue is still there?

My steps:
2) WiFi off and data(3G) enabled
3) Open contacts
4) Click on the gear icon to open settings
5) Select to import contacts, showing Gmail or outlook account
6) While the email sign in screen is active (or not), open the utility tray and enable wifi
7) Wait and wifi panel is opened and enabled

Comment 14

[[e-mail]]

Set qawanted for retesting this issue.

Comment 15

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

This issue still occurs on the latest Aries and Flame builds.  Please note that Wifi must be disabled (the switch turned to off in settings) not just not being connected.

Environmental Variables:
Device: Flame Master
BuildID: 20150811030209
Gaia: 9a8880a95ee4a4aea7895d4e2bcab31bc49ea281
Gecko: 8cba870a352c
Gonk: c4779d6da0f85894b1f78f0351b43f2949e8decd
Version: 43.0a1 (Master) 
Firmware Version: v18D-1
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Environmental Variables:
Device: Aries Master
BuildID: 20150811155235
Gaia: 2d7f369fd923b6df3b00d76844c413c1202c04ba
Gecko: 38c1ea9ccae31700630f1fe0d651e94c0c5b9e1d
Gonk: 2916e2368074b5383c80bf5a0fba3fc83ba310bd
Version: 43.0a1 (Master) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:43.0) Gecko/43.0 Firefox/43.0

Comment 16

[[e-mail]]

I can 100% reproduce by 

1. open UI tests app > window.open
2. press window.open button
3. open the utility tray and enable wifi

Therefore it looks more like a window management bug related to handle popup window -> activity window

Comment 17

[Etienne Segonzac (:etienne)]

Hey Alberto, this looks similar to bug 1194736, but I can still reproduce it. Any idea?

Comment 18

[Alberto Pastor [:albertopq]]

It doesn't seem related to bug 1194736 (in that case, the chrome was the div taking that space, and is not in here). As per comment #7, it looks like inline activities never worked properly on PopupWindows. I'll take a look.

Thanks!

Comment 19

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1180027-blank-inline-activity > mozilla-b2g:master

Comment 20

[Etienne Segonzac (:etienne)]

Comment on attachment 8657757 [details] [review]
[gaia] albertopq:1180027-blank-inline-activity > mozilla-b2g:master

lgtm!

Comment 21

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/cb0d5cfdc7aaf5971081c40d91e6782a8642227b

Comment 22

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.5 and Aires KK 2.5 by the STR in comment 0.

Actual results: There is no any blank area at the top of the WiFi settings if the user enables WiFi while trying to sign into an email account to import contacts.
See attachment: verified_Flame&Aries_v2.5.3gp
Reproduce rate: 0/10


Device: Flame KK 2.5 (Pass)
Build ID               20150910150202
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/7671701d15cadd2b343fc27685231e0689bb71df
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150910.182915
Firmware Date          Thu Sep 10 18:29:25 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.5 (Pass)
Build ID               20150911000328
Gaia Revision          6280500a6cb8d1b178cdd163450e36d22846fbed
Gaia Date              2015-09-10 11:38:24
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/c0abc2a6e11f52761366e029eb1bae4c9864a8a3
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150910.232411
Firmware Date          Thu Sep 10 23:24:19 UTC 2015
Bootloader             s1

Comment 23

[Shally Li（leave from Mozilla）]

Attachment: verified_Flame&Aries_v2.5.3gp