Last Comment Bug 1180478 - Remove aero from the tree. Part 2 (chat)
: Remove aero from the tree. Part 2 (chat)
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Theme (show other bugs)
: unspecified
: All Windows
-- normal (vote)
: Thunderbird 42.0
Assigned To: Richard Marti (:Paenglab)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2015-07-05 01:46 PDT by Richard Marti (:Paenglab)
Modified: 2015-08-07 13:56 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
No-chat-aero.patch (22.73 KB, patch)
2015-07-05 01:49 PDT, Richard Marti (:Paenglab)
no flags Details | Diff | Splinter Review
No-chat-aero.patch (22.92 KB, patch)
2015-08-01 02:14 PDT, Richard Marti (:Paenglab)
philipp: review+
Details | Diff | Splinter Review
No-chat-aero.patch (22.92 KB, patch)
2015-08-06 03:12 PDT, Richard Marti (:Paenglab)
richard.marti: review+
Details | Diff | Splinter Review

Description User image Richard Marti (:Paenglab) 2015-07-05 01:46:24 PDT
Second part for chat to remove the aero files.
Comment 1 User image Richard Marti (:Paenglab) 2015-07-05 01:49:16 PDT
Created attachment 8629640 [details] [diff] [review]
No-chat-aero.patch

Remove chat-aero.css corresponding icon will be renamed with the final patch for completely removing the aero tree.
Comment 2 User image Richard Marti (:Paenglab) 2015-08-01 02:14:58 PDT
Created attachment 8642012 [details] [diff] [review]
No-chat-aero.patch

I've added a rule on Win8 and Win10 to use the old close icon in the conversation list after landing of bug 1173729. The new default icon is too big in this place.
Comment 3 User image Richard Marti (:Paenglab) 2015-08-05 05:46:21 PDT
Comment on attachment 8642012 [details] [diff] [review]
No-chat-aero.patch

Blake has ho possibility to review this patch for a couple of weeks. Changing to Philipp.
Comment 4 User image Philipp Kewisch [:Fallen] 2015-08-06 01:32:25 PDT
Comment on attachment 8642012 [details] [diff] [review]
No-chat-aero.patch

Review of attachment 8642012 [details] [diff] [review]:
-----------------------------------------------------------------

r=philipp
Comment 5 User image Richard Marti (:Paenglab) 2015-08-06 03:12:06 PDT
Created attachment 8644244 [details] [diff] [review]
No-chat-aero.patch

Updated the commit message to r=Fallen
Comment 6 User image aleth [:aleth] 2015-08-07 13:54:31 PDT
url:        https://hg.mozilla.org/comm-central/rev/4ae808ea57dd56377d0a926ed3ac9f8d8cf991e5
changeset:  4ae808ea57dd56377d0a926ed3ac9f8d8cf991e5
user:       Richard Marti <richard.marti@gmail.com>
date:       Sun Jul 05 10:23:53 2015 +0200
description:
Bug 1180478 - Get rid of chat-aero.css. r=Fallen

Note You need to log in before you can comment on or make changes to this bug.