1181238 - Navigating to a new URL while focused on a text field breaks browser layout

Status: RESOLVED FIXED

(Firefox for iOS :: Browser, defect)

Description

[Brian Nicholson (:bnicholson)]

STR:
1) Go to google.com.
2) Tap the search text field.
3) Tap the URL bar and navigate to another URL.

After these steps, a bunch of SnapKit errors appear in the log, the toolbar floats to the middle of the screen, and scrolling is broken.

Comment 1

[Bryan Munar (:bkmunar)]

Think I know the problem since this also happens:

STR:
1) Go to yahoo.com
2) Tap the search text field.
3) Tap the URL bar, cancel, then same error happens

Comment 2

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 3

[Brian Nicholson (:bnicholson)]

Comment on attachment 8633312 [details] [review]
PR

Still breaks in a number of other situations as pointed out. Rather than trying to hide the input switcher, we should figure out why the input switcher is breaking constraints to begin with.

Comment 4

[Bryan Munar (:bkmunar)]

Changed it!

Comment 5

[Bryan Munar (:bkmunar)]

Also, emily wrote the function so she will add some backup review

Comment 6

[Brian Nicholson (:bnicholson)]

Comment on attachment 8633312 [details] [review]
PR

Nice fix! Looks good to me with a suggestion in the PR.

Comment 7

[Emily Toop (:fluffyemily)]

Comment on attachment 8633312 [details] [review]
PR

LGTM