The default bug view has changed. See this FAQ.

[AccessFu][Androd] local menu improvements

RESOLVED FIXED in Firefox 43

Status

()

Core
Disability Access APIs
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: yzen, Assigned: eeejay)

Tracking

(Blocks: 1 bug, {access})

unspecified
mozilla43
ARM
Android
access
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

2 years ago
Here's a list of potential improvements we can take on:

* line granularity
* section navigation (like landmark)
* list navigation
* control navigation  -> we might be able to do that based on things being actionable
* special content navigation [??]
(Assignee)

Comment 1

2 years ago
Created attachment 8651221 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

This patch makes the local context menu identical to Chrome. The behavior is slightly different for the different granularity settings.
* Character/Word/Paragraph act the same as they did before.
* "Control" skips between actionable items, including links.
* "List" skips to the first item on any list on the page. This is instead of putting the cursor on the entire list.
* "Section" skips to landmarks. I think it would be smart if this also went to headings, since that is de-facto how pages are organized when they don't use other kinds of landmarks. WHat do you think?

I'll add a link to a try run for a quick doenload of a build.
Attachment #8651221 - Flags: feedback?
(Assignee)

Comment 2

2 years ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e95056ba473d
(Assignee)

Updated

2 years ago
Attachment #8651221 - Flags: feedback? → feedback?(mzehe)
(Assignee)

Updated

2 years ago
Assignee: nobody → eitan

Comment 3

2 years ago
When I try to open the build directory for this try build, I get an "artifact not found" error message. :(

Comment 4

2 years ago
Comment on attachment 8651221 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

cancelling feedback until we have a working try build. Tried to build locally, but for some reason the patch doesn't apply cleanly, and afterwards I get build errors.
Attachment #8651221 - Flags: feedback?(mzehe)
(Assignee)

Comment 5

2 years ago
Created attachment 8652529 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

Rebased.
Attachment #8651221 - Attachment is obsolete: true

Comment 6

2 years ago
Comment on attachment 8652529 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

This works partially. The normal navigation works. The Navigation by Control Types also works, but I got neither lists, nor special items, nor sections to work.

Also, if I set TalkBack to show the context menu as a list, when returning to Fennec after dismissing that list, the new setting is not retained, but reset to the default granularity.

Comment 7

2 years ago
Eitan, have you been able to verify my findings from the previous comment? What's the status here?

Updated

2 years ago
Flags: needinfo?(eitan)
(Assignee)

Comment 8

2 years ago
Indeed! I have incorporated all of your input. Expect a new patch soon.
Flags: needinfo?(eitan)
(Assignee)

Comment 9

2 years ago
Created attachment 8659477 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.
Attachment #8659477 - Flags: review?(yzenevich)
Attachment #8659477 - Flags: review?(mark.finkle)
(Assignee)

Updated

2 years ago
Blocks: 1203697
Comment on attachment 8659477 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

This patch works as expected! Including showing the local context menu as list.Also the different granularities work as I would expect them to.
(Reporter)

Comment 11

2 years ago
Comment on attachment 8659477 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

Review of attachment 8659477 [details] [diff] [review]:
-----------------------------------------------------------------

JS part looks good, see one suggestion

::: accessible/jsat/AccessFu.jsm
@@ +311,4 @@
>        case 'Accessibility:PreviousObject':
> +      {
> +        let rule = aData ?
> +          aData.substr(0, 1).toUpperCase() + aData.substr(1).toLowerCase() :

can also do
aData.toLowerCase().replace(/^./, c => c.toUpperCase())
Attachment #8659477 - Flags: review?(yzenevich) → review+
Comment on attachment 8659477 [details] [diff] [review]
Make Layerview support accessibility HTML navigation.

Looks OK to me.
Attachment #8659477 - Flags: review?(mark.finkle) → review+

Comment 13

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/2ed46aca6ae0
https://hg.mozilla.org/mozilla-central/rev/2ed46aca6ae0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla43

Comment 15

2 years ago
@Eeejay: I think including headings in section navigattion is a very good idea. Few sites have landmarks, but almost all do have headings....
You need to log in before you can comment on or make changes to this bug.