Closed Bug 1182222 Opened 9 years ago Closed 9 years ago

[AccessFu][Androd] local menu improvements

Categories

(Core :: Disability Access APIs, defect)

ARM
Android
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla43
Tracking Status
firefox43 --- fixed

People

(Reporter: yzen, Assigned: eeejay)

References

Details

(Keywords: access)

Attachments

(2 files, 1 obsolete file)

Here's a list of potential improvements we can take on: * line granularity * section navigation (like landmark) * list navigation * control navigation -> we might be able to do that based on things being actionable * special content navigation [??]
This patch makes the local context menu identical to Chrome. The behavior is slightly different for the different granularity settings. * Character/Word/Paragraph act the same as they did before. * "Control" skips between actionable items, including links. * "List" skips to the first item on any list on the page. This is instead of putting the cursor on the entire list. * "Section" skips to landmarks. I think it would be smart if this also went to headings, since that is de-facto how pages are organized when they don't use other kinds of landmarks. WHat do you think? I'll add a link to a try run for a quick doenload of a build.
Attachment #8651221 - Flags: feedback?
Attachment #8651221 - Flags: feedback? → feedback?(mzehe)
Assignee: nobody → eitan
When I try to open the build directory for this try build, I get an "artifact not found" error message. :(
Comment on attachment 8651221 [details] [diff] [review] Make Layerview support accessibility HTML navigation. cancelling feedback until we have a working try build. Tried to build locally, but for some reason the patch doesn't apply cleanly, and afterwards I get build errors.
Attachment #8651221 - Flags: feedback?(mzehe)
Rebased.
Attachment #8651221 - Attachment is obsolete: true
Comment on attachment 8652529 [details] [diff] [review] Make Layerview support accessibility HTML navigation. This works partially. The normal navigation works. The Navigation by Control Types also works, but I got neither lists, nor special items, nor sections to work. Also, if I set TalkBack to show the context menu as a list, when returning to Fennec after dismissing that list, the new setting is not retained, but reset to the default granularity.
Eitan, have you been able to verify my findings from the previous comment? What's the status here?
Flags: needinfo?(eitan)
Indeed! I have incorporated all of your input. Expect a new patch soon.
Flags: needinfo?(eitan)
Attachment #8659477 - Flags: review?(yzenevich)
Attachment #8659477 - Flags: review?(mark.finkle)
Blocks: 1203697
Comment on attachment 8659477 [details] [diff] [review] Make Layerview support accessibility HTML navigation. This patch works as expected! Including showing the local context menu as list.Also the different granularities work as I would expect them to.
Comment on attachment 8659477 [details] [diff] [review] Make Layerview support accessibility HTML navigation. Review of attachment 8659477 [details] [diff] [review]: ----------------------------------------------------------------- JS part looks good, see one suggestion ::: accessible/jsat/AccessFu.jsm @@ +311,4 @@ > case 'Accessibility:PreviousObject': > + { > + let rule = aData ? > + aData.substr(0, 1).toUpperCase() + aData.substr(1).toLowerCase() : can also do aData.toLowerCase().replace(/^./, c => c.toUpperCase())
Attachment #8659477 - Flags: review?(yzenevich) → review+
Comment on attachment 8659477 [details] [diff] [review] Make Layerview support accessibility HTML navigation. Looks OK to me.
Attachment #8659477 - Flags: review?(mark.finkle) → review+
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla43
@Eeejay: I think including headings in section navigattion is a very good idea. Few sites have landmarks, but almost all do have headings....
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: