Panning right with a braille display should eventually navigate to the next item

RESOLVED FIXED in Firefox 43

Status

()

Firefox for Android
General
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 43
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox43 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

2 years ago
STR:

1. Enable Talkback and Brailleback (I use the debug on-screen braille display option).
2. Go to a web page, navigate with Talkback to a heading, either with swipe or explore by touch.
3. In the braille display, press the right button to scroll through the full text of the heading.
4. After reaching the end of the text, another press of the button does nothing.

Expected:

Pressing the button again should bring you to the next item.
(Assignee)

Comment 2

2 years ago
Created attachment 8659479 [details] [diff] [review]
Add braille navigation.
Attachment #8659479 - Flags: review?(yzenevich)
Attachment #8659479 - Flags: review?(mark.finkle)
Attachment #8659479 - Flags: feedback?(maxli)
(Assignee)

Comment 3

2 years ago
This patch depends on the patch in bug 1182222, that makes our web view an official android a11y web view.
Depends on: 1182222

Comment 4

2 years ago
Comment on attachment 8659479 [details] [diff] [review]
Add braille navigation.

OK, something weird is going on here. it pans to a next and previous item, but it's not the next or previous item one would swipe to. Instead, the Android Section rule or something similar seems to be applied. I tried this page:

https://support.mozilla.org/en-US/kb/how-use-talkback-support-firefox

1. I then start from somewhere at the top, for example by touching the heading in the main section "How to use TalkBack support in Firefox for Android for accessibility".

2. I pan through this heading without problems.
3. Next pan brings me to the next element, but TalkBack reads the whole huge bunch, as if it was all just one big thing lumped together, including the table of contents and other items. So it doesn't move to the paragraph that follows the heading, but to the container that encompasses it.
4. When I get to the end of the paragraph, and pan right, I land on the "Share this page" heading way down at the bottom.
5. If I pan left, I land back on the start of step 3, not the just previous section or item.
6. Similarly, if I touch somewhere within the main article, for example on some link in the Table Of Contents, and then pan right, I land on "Share this page", as in step 4. If I pan left, I land at the beginning of the main content, below the heading, as in step 3.

It would appear that panning, when it should traverse to the next or previous element, uses the wrong granularity somehow. Normal swiping on the touch screen works as expected.

This is all with the test build you sent me, Eitan.
Comment on attachment 8659479 [details] [diff] [review]
Add braille navigation.

Review of attachment 8659479 [details] [diff] [review]:
-----------------------------------------------------------------

removing the flag since Marco's noticing some weirdness, question inline.

::: accessible/jsat/AccessFu.jsm
@@ +866,1 @@
>          this.moveCursor('move' + aDetails.direction, 'Paragraph', 'gesture');

Just based on Marco's feedback do we need a Line traversal rule by any chance?
Attachment #8659479 - Flags: review?(yzenevich)
(Assignee)

Comment 6

2 years ago
I am going to use the Simple traversal rule in the next patch. I think that is what Marco was expecting anyway.
(Assignee)

Comment 7

2 years ago
Created attachment 8660844 [details] [diff] [review]
Add braille navigation.

Changed rule to Simple, it should be a lot simpler now :)
Attachment #8659479 - Attachment is obsolete: true
Attachment #8659479 - Flags: review?(mark.finkle)
Attachment #8659479 - Flags: feedback?(maxli)
Attachment #8660844 - Flags: review?(yzenevich)
Attachment #8660844 - Flags: review?(mark.finkle)
Attachment #8660844 - Flags: feedback?
Comment on attachment 8660844 [details] [diff] [review]
Add braille navigation.

Code looks fine to me
Attachment #8660844 - Flags: review?(mark.finkle) → review+
Comment on attachment 8660844 [details] [diff] [review]
Add braille navigation.

Review of attachment 8660844 [details] [diff] [review]:
-----------------------------------------------------------------

looks good
Attachment #8660844 - Flags: review?(yzenevich) → review+
(Assignee)

Updated

2 years ago
Attachment #8660844 - Flags: feedback?

Comment 10

2 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b10bb607c2f0
https://hg.mozilla.org/mozilla-central/rev/b10bb607c2f0
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
You need to log in before you can comment on or make changes to this bug.