1182976 - Use nsTHashTable::Iterator in dom/{html,quota,broadcastchannel}/

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nicholas Nethercote [inactive]]

Because iterators are so much nicer than enumerate functions.

There are nine occurrences of EnumerateEntries() in  dom/{html,quota,broadcastchannel,workers}/ to be dealt with.

Comment 1

[(no longer active)]

There should be nothing more in workers after the above two bugs get fixed.

Comment 2

[Nicholas Nethercote [inactive]]

Let's just rename this bug to be about the three non-workers/ cases.

Comment 3

[(no longer active)]

Attachment: Part 1: Get rid of IdentifierMapEntryAddNames

Comment 4

[(no longer active)]

Attachment: Part 2: Get rid of the Helper class in QuotaManager::OpenDirectoryInternal

Comment 5

[(no longer active)]

Attachment: Part 3: Get rid of PostMessageEnumerator

Comment 6

[Jan Varga [:janv]]

Comment on attachment 8634528 [details] [diff] [review]
Part 2: Get rid of the Helper class in QuotaManager::OpenDirectoryInternal

Review of attachment 8634528 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 7

[Nicholas Nethercote [inactive]]

Comment on attachment 8634527 [details] [diff] [review]
Part 1: Get rid of IdentifierMapEntryAddNames

Review of attachment 8634527 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/html/nsHTMLDocument.cpp
@@ +2322,5 @@
>  void
>  nsHTMLDocument::GetSupportedNames(unsigned, nsTArray<nsString>& aNames)
>  {
> +  for (auto iter = mIdentifierMap.Iter(); !iter.Done(); iter.Next()) {
> +    if (iter.Get()->HasNameElement() ||

Drive-by comment: I would factor out |nsIdentifierMapEntry* entry = iter.Get();|.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6295cf259176
https://hg.mozilla.org/integration/mozilla-inbound/rev/4c5436d8132f
https://hg.mozilla.org/integration/mozilla-inbound/rev/612a304c643d

Comment 9

[(no longer active)]

(In reply to Nicholas Nethercote [:njn] from comment #7)
> ::: dom/html/nsHTMLDocument.cpp
> @@ +2322,5 @@
> >  void
> >  nsHTMLDocument::GetSupportedNames(unsigned, nsTArray<nsString>& aNames)
> >  {
> > +  for (auto iter = mIdentifierMap.Iter(); !iter.Done(); iter.Next()) {
> > +    if (iter.Get()->HasNameElement() ||
> 
> Drive-by comment: I would factor out |nsIdentifierMapEntry* entry =
> iter.Get();|.

Sorry, missed this!  Addressed in https://hg.mozilla.org/integration/mozilla-inbound/rev/562a0a1d3dbc.

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6295cf259176
https://hg.mozilla.org/mozilla-central/rev/4c5436d8132f
https://hg.mozilla.org/mozilla-central/rev/612a304c643d
https://hg.mozilla.org/mozilla-central/rev/562a0a1d3dbc