Closed
Bug 1182976
Opened 9 years ago
Closed 9 years ago
Use nsTHashTable::Iterator in dom/{html,quota,broadcastchannel}/
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla42
Tracking | Status | |
---|---|---|
firefox42 | --- | fixed |
People
(Reporter: n.nethercote, Assigned: ehsan.akhgari)
References
Details
Attachments
(3 files)
1.35 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
2.15 KB,
patch
|
janv
:
review+
|
Details | Diff | Splinter Review |
4.18 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Because iterators are so much nicer than enumerate functions. There are nine occurrences of EnumerateEntries() in dom/{html,quota,broadcastchannel,workers}/ to be dealt with.
Assignee | ||
Comment 1•9 years ago
|
||
There should be nothing more in workers after the above two bugs get fixed.
Reporter | ||
Comment 2•9 years ago
|
||
Let's just rename this bug to be about the three non-workers/ cases.
Assignee | ||
Updated•9 years ago
|
Assignee: nobody → ehsan
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8634527 -
Flags: review?(amarchesini)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8634528 -
Flags: review?(Jan.Varga)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8634529 -
Flags: review?(amarchesini)
Comment 6•9 years ago
|
||
Comment on attachment 8634528 [details] [diff] [review] Part 2: Get rid of the Helper class in QuotaManager::OpenDirectoryInternal Review of attachment 8634528 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8634528 -
Flags: review?(Jan.Varga) → review+
Reporter | ||
Comment 7•9 years ago
|
||
Comment on attachment 8634527 [details] [diff] [review] Part 1: Get rid of IdentifierMapEntryAddNames Review of attachment 8634527 [details] [diff] [review]: ----------------------------------------------------------------- ::: dom/html/nsHTMLDocument.cpp @@ +2322,5 @@ > void > nsHTMLDocument::GetSupportedNames(unsigned, nsTArray<nsString>& aNames) > { > + for (auto iter = mIdentifierMap.Iter(); !iter.Done(); iter.Next()) { > + if (iter.Get()->HasNameElement() || Drive-by comment: I would factor out |nsIdentifierMapEntry* entry = iter.Get();|.
Updated•9 years ago
|
Attachment #8634527 -
Flags: review?(amarchesini) → review+
Updated•9 years ago
|
Attachment #8634529 -
Flags: review?(amarchesini) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/6295cf259176 https://hg.mozilla.org/integration/mozilla-inbound/rev/4c5436d8132f https://hg.mozilla.org/integration/mozilla-inbound/rev/612a304c643d
Assignee | ||
Comment 9•9 years ago
|
||
(In reply to Nicholas Nethercote [:njn] from comment #7) > ::: dom/html/nsHTMLDocument.cpp > @@ +2322,5 @@ > > void > > nsHTMLDocument::GetSupportedNames(unsigned, nsTArray<nsString>& aNames) > > { > > + for (auto iter = mIdentifierMap.Iter(); !iter.Done(); iter.Next()) { > > + if (iter.Get()->HasNameElement() || > > Drive-by comment: I would factor out |nsIdentifierMapEntry* entry = > iter.Get();|. Sorry, missed this! Addressed in https://hg.mozilla.org/integration/mozilla-inbound/rev/562a0a1d3dbc.
Comment 10•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/6295cf259176 https://hg.mozilla.org/mozilla-central/rev/4c5436d8132f https://hg.mozilla.org/mozilla-central/rev/612a304c643d https://hg.mozilla.org/mozilla-central/rev/562a0a1d3dbc
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox42:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•