1183135 - [e10s] tab separators update synchronously before tab becomes visuallyselected

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Markus Stange [:mstange]]

Attachment: screen recording

If I switch tabs using Cmd+Option+left/right quickly, I can see the tab separator to the right of the targeted tab disappear before the rest of the tab styling updates once the content process responds.

I'm attaching a screen recording but it's a little hard to see unless you step through it frame by frame.

Comment 1

[arni2033]

Thanks G-d you already have this bug. Noone would believe me if I reported it myself

Here's my video (WEBM) and some of my thoughts [mark this comment as obsolete if it isn't helpful]
https://dl.dropboxusercontent.com/s/zxiwp2hvvzmzlc1/Bug%201183135%20-%20%5Be10s%5D%20tab%20separators%20update%20synchronously%20before%20tab%20becomes%20visuallyselected.webm?dl=0

Thoughts:   According to this selector,
http://mxr.mozilla.org/mozilla-central/source/browser/themes/shared/tabs.inc.css#434
and given that tab[visuallyselected] gets white color and curved borders, I conclude that separators update because "afterselected-visible" attribute being set to tab after selected. That attr is being set quickly, but attr "visuallyselected" is being set slowly, only after target tab is loaded (I suppose)

So I see 3 solutions here:
1) to set "afterselected-visible" as slow as "visuallyselected"   [synchronize]
2) to set "visuallyselected" as fast as "afterselected-visible"   [synchronize]
3) do (1) or (2) AND somehow speed up loading tabs in e10s (way harder then just setting attributes)

Comment 2

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

I haven't managed to reproduce this issue on the latest Aurora build(46.0a2). On the latest Nightly(47.0a1) this reproduced only once. I've tried again, but I was unable to reproduce it afterwards on the same Mac OS 10.11.

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160207004019

I've also tested on Windows 7 x32 and Ubuntu 14.04, on both Aurora and Nightly, but I wasn't able to reproduce it.

Comment 3

[arni2033]

STR:
1. Open the following "data:" url in a new window. Close other tabs in that window
>   data:text/html,<a href="http://www.rp-online.de/">Link</a>
2. Middle-click that Link 10 times at the speed >= 1 middleclick per second
3. Close the tab with "data:" url. You'll get 10 tabs with the "heavy" site
4. Press Ctrl+PageDown 10 times as fast as possible (2-3 pressings per second)
5. If you still don't see the bug:   do {Ctrl+Shift+Tab, then Ctrl+Shift+R} 10 times, repeat Step 4

I usually have 40+ tabs opened, so I only need Step 4 to reproduce.

Comment 4

[Paul Pasca[Away. Please needinfo? Paul Oiegas [:pauloiegasSV]]]

Thanks Arni2033 for the additional details. I was able to reproduce this issue following your latest steps on Windows 7 x32 and Mac OS 10.11, using both latest Aurora(46.0a2) and latest Nightly(47.0a1). This bug only appears when e10s is enabled, otherwise tab switching works correctly without tab separator disappearing.

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160209004008

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160208030244

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:46.0) Gecko/20100101 Firefox/46.0
Build ID: 20160209004008

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:47.0) Gecko/20100101 Firefox/47.0
Build ID: 20160209030347

Comment 8

[Dão Gottwald [:dao]]

Attachment: Bug 1183135 - Update tab position attributes when a tab becomes visually selected rather than synchronously when switching tabs.

Review commit: https://reviewboard.mozilla.org/r/240554/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/240554/

Comment 9

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8971805 [details]
Bug 1183135 - Update tab position attributes when a tab becomes visually selected rather than synchronously when switching tabs.

https://reviewboard.mozilla.org/r/240554/#review246726

Looks good, thanks!

::: browser/base/content/test/tabs/browser_positional_attributes.js:17
(Diff revision 1)
> -  is(elem.hasAttribute(attrib), attribValue, msg);
> +  return BrowserTestUtils.switchTab(gBrowser, gBrowser.tabs[index]);
> +}
> +
> +function testAttrib(tabIndex, attrib, expected) {
> +  is(gBrowser.tabs[tabIndex].hasAttribute(attrib), expected,
> +     `tab #${tabIndex} should${expected ? "" : "n't"} have the ${attrib} attribute`);

Typo: "n't" -> "not".

Comment 10

[Dão Gottwald [:dao]]

(In reply to Mike Conley (:mconley) (:⚙️) (Totally backlogged on reviews and needinfos) from comment #9)
> ::: browser/base/content/test/tabs/browser_positional_attributes.js:17
> (Diff revision 1)
> > -  is(elem.hasAttribute(attrib), attribValue, msg);
> > +  return BrowserTestUtils.switchTab(gBrowser, gBrowser.tabs[index]);
> > +}
> > +
> > +function testAttrib(tabIndex, attrib, expected) {
> > +  is(gBrowser.tabs[tabIndex].hasAttribute(attrib), expected,
> > +     `tab #${tabIndex} should${expected ? "" : "n't"} have the ${attrib} attribute`);
> 
> Typo: "n't" -> "not".

Not a typo ;)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee1e498e3c43
Update tab position attributes when a tab becomes visually selected rather than synchronously when switching tabs. r=mconley

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/ee1e498e3c43

Comment 13

[Ed Lee :Mardak]

Attachment: screenshots from browser_tabclose

Looks like this change introduced a frequent intermittent that sheriffs have been starring as bug 1448497:

TEST-UNEXPECTED-FAIL | browser/base/content/test/performance/browser_tabclose.js | unexpected changed rect: ({x1:0, x2:223, y1:0, y2:32, w:224, h:33}), window width: 1280 -

https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=ee1e498e3c433bb57de697fe68c3f6e61969c110&filter-searchStr=lin%20(bc6

I've attached a screenshot of the 2 data uris that the test prints out.

Comment 14

[Ionuț Goldan [:igoldan]]

We won some perf improvements!

== Change summary for alert #13023 (as of Wed, 02 May 2018 07:35:26 GMT) ==

Improvements:

  3%  tps windows10-64 opt e10s stylo     14.67 -> 14.19
  3%  tps windows10-64 pgo e10s stylo     13.12 -> 12.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=13023

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/ce588e44f415
Backed out changeset ee1e498e3c43 for failing browser chrome tests on browser/base/content/test/performance/browser_tabclose.js a=backout

Comment 16

[Arthur Iakab [arthur_iakab]]

Backed out changeset ee1e498e3c43 (bug 1183135) for failing browser chrome tests on browser/base/content/test/performance/browser_tabclose.js a=backout 
Failure log:https://treeherder.mozilla.org/logviewer.html#?job_id=176647398&repo=mozilla-central&lineNumber=2877
Backout revision https://hg.mozilla.org/mozilla-central/rev/ce588e44f41599808a830db23d190d1ca474a781
Failing push:https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&revision=f877359308b17e691209e1afb7193b8e86f175ce&filter-searchStr=lin%20(bc6

Comment 17

[Dão Gottwald [:dao]]

Comment on attachment 8971805 [details]
Bug 1183135 - Update tab position attributes when a tab becomes visually selected rather than synchronously when switching tabs.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/240554/diff/1-2/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c07ba1f49f5e
Update tab position attributes when a tab becomes visually selected rather than synchronously when switching tabs. r=mconley

Comment 19

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c07ba1f49f5e

Comment 20

[Cristian Craciun]

Managed to reproduce the issue on Firefox Nightly (2015-07-13) on Windows 10, Mac OS X 10.11 and Ubuntu 16.04 x64 using the steps provided in Comment 3. 

The issue cannot be reproduced on the latest Nightly Firefox 61.0a1. (20180503220110 / 2018-05-03) on Windows 10, Mac OS X 10.11 and Ubuntu 16.04 x64, thus I will close the issue as VERIFIED FIXED.