Create a markers directory temporarily inside docshell/base where all marker logic should go into

RESOLVED FIXED in Firefox 42

Status

RESOLVED FIXED
4 years ago
6 months ago

People

(Reporter: vporof, Assigned: vporof)

Tracking

unspecified
Firefox 42

Firefox Tracking Flags

(firefox42 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

4 years ago
First step towards taking all the markers logic outside docshells.

Once everything is moved out, we may consider moving that directory somewhere else, but in the meantime, it's a good way to start things going.
(Assignee)

Comment 1

3 years ago
Created attachment 8634399 [details] [diff] [review]
v1
Assignee: nobody → vporof
Status: NEW → ASSIGNED
Attachment #8634399 - Flags: review?(ttromey)
(Assignee)

Comment 2

3 years ago
Best look at the raw patch file instead of splinter review.

Updated

3 years ago
Attachment #8634399 - Flags: review?(ttromey) → review?(bugs)
Comment on attachment 8634399 [details] [diff] [review]
v1

Well, you'll need proper moz.build then in timeline/ at some point, so why not do it now?
Just creating the directory, but not integrating it with the build system feels odd.
Attachment #8634399 - Flags: review?(bugs) → review-
...since it doesn't really help with anything.
(Assignee)

Comment 6

3 years ago
Sounds good, will update the patch.
(Assignee)

Comment 7

3 years ago
Created attachment 8635422 [details] [diff] [review]
v2

With moz.build
Attachment #8634399 - Attachment is obsolete: true
Attachment #8635422 - Flags: review?(bugs)
Comment on attachment 8635422 [details] [diff] [review]
v2

Don't you want 
/docshell/base/timeline in local includes in the original moz.build, and then no need for the
change in nsDocShell.h
Attachment #8635422 - Flags: review?(bugs) → review+
(Assignee)

Comment 10

3 years ago
(In reply to Olli Pettay [:smaug] (review overload) from comment #9)
> Comment on attachment 8635422 [details] [diff] [review]
> v2
> 
> Don't you want 
> /docshell/base/timeline in local includes in the original moz.build, and
> then no need for the
> change in nsDocShell.h

Meh. I guess it would be more elegant indeed. I'll file a followup for this so I don't have to rebase everything.
(Assignee)

Comment 11

3 years ago
Filed bug 1185175.
https://hg.mozilla.org/mozilla-central/rev/12c6b2a7799f
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 42

Updated

6 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.