1183223 - Create a markers directory temporarily inside docshell/base where all marker logic should go into

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Victor Porof [:vporof][:vp]]

First step towards taking all the markers logic outside docshells.

Once everything is moved out, we may consider moving that directory somewhere else, but in the meantime, it's a good way to start things going.

Comment 1

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 2

[Victor Porof [:vporof][:vp]]

Best look at the raw patch file instead of splinter review.

Comment 3

[Victor Porof [:vporof][:vp]]

Patch queue: https://pastebin.mozilla.org/8839722

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8634399 [details] [diff] [review]
v1

Well, you'll need proper moz.build then in timeline/ at some point, so why not do it now?
Just creating the directory, but not integrating it with the build system feels odd.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

...since it doesn't really help with anything.

Comment 6

[Victor Porof [:vporof][:vp]]

Sounds good, will update the patch.

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: v2

With moz.build

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/12c6b2a7799f

Comment 9

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8635422 [details] [diff] [review]
v2

Don't you want 
/docshell/base/timeline in local includes in the original moz.build, and then no need for the
change in nsDocShell.h

Comment 10

[Victor Porof [:vporof][:vp]]

(In reply to Olli Pettay [:smaug] (review overload) from comment #9)
> Comment on attachment 8635422 [details] [diff] [review]
> v2
> 
> Don't you want 
> /docshell/base/timeline in local includes in the original moz.build, and
> then no need for the
> change in nsDocShell.h

Meh. I guess it would be more elegant indeed. I'll file a followup for this so I don't have to rebase everything.

Comment 11

[Victor Porof [:vporof][:vp]]

Filed bug 1185175.

Comment 12

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/12c6b2a7799f