Implement updated design of 'Import' and 'Add new contact' buttons

RESOLVED FIXED in Firefox 42

Status

defect
P1
normal
Rank:
17
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: mikedeboer, Assigned: andreio)

Tracking

unspecified
mozilla42
Points:
2
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox42 fixed)

Details

(Whiteboard: [visual refresh])

Attachments

(4 attachments, 2 obsolete attachments)

As the acceptance criteria in bug 1179210 states:

 - "Import" and "Add new contact" button layout refresh

For the visual design spec, please check out the ones attached to bug 1179210.
Flags: qe-verify+
Flags: firefox-backlog+
Assignee: nobody → andrei.br92
Attachment #8635025 - Attachment is obsolete: true
I've attached 2 screenshots of the buttons (with and without line break). Depending on the length of the strings the buttons might look different. How should be handle this?
Flags: needinfo?(sfranks)
Deferring to Vicky.
Flags: needinfo?(sfranks) → needinfo?(vpg)
(In reply to Andrei Oprea [:andreio] from comment #5)
> I've attached 2 screenshots of the buttons (with and without line break).
> Depending on the length of the strings the buttons might look different. How
> should be handle this?

Andrei, this solution is OK for an edge case, but in general we'll advocate for the minimal copy for buttons, it is not good practice to have long text in buttons. On the other hand the rest of the UI I think it is WIP, right? Thanks!
Flags: needinfo?(vpg)
(In reply to Victoria Gerchinhoren [:vicky] from comment #7)
> (In reply to Andrei Oprea [:andreio] from comment #5)
> > I've attached 2 screenshots of the buttons (with and without line break).
> > Depending on the length of the strings the buttons might look different. How
> > should be handle this?
> 
> Andrei, this solution is OK for an edge case, but in general we'll advocate
> for the minimal copy for buttons, it is not good practice to have long text
> in buttons.

We need to remember that localised languages can't always cope with minimal copy (what's minimal in one language isn't always in every language), therefore we need to be happy with the design for both.
(In reply to Mark Banner (:standard8) from comment #8)
> (In reply to Victoria Gerchinhoren [:vicky] from comment #7)
> > (In reply to Andrei Oprea [:andreio] from comment #5)
> > > I've attached 2 screenshots of the buttons (with and without line break).
> > > Depending on the length of the strings the buttons might look different. How
> > > should be handle this?
> > 
> > Andrei, this solution is OK for an edge case, but in general we'll advocate
> > for the minimal copy for buttons, it is not good practice to have long text
> > in buttons.
> 
> We need to remember that localised languages can't always cope with minimal
> copy (what's minimal in one language isn't always in every language),
> therefore we need to be happy with the design for both.

yes, I am aware of that, that's why I gave the OK. But it is also important to try to keep the buttons text clear and short (for instance if you're already in the contacts list, you don't need to write "import contact" when "import" is enough). When this is not possible, the 2 lines are OK as an edge case.
Attachment #8635027 - Attachment is obsolete: true
Comment on attachment 8636836 [details] [diff] [review]
Implement updated design of contact buttons

This just adds the style for the buttons and moves them in the right place. The margins/positioning are not correct but I expect that to be handled in bug 1183636.
Attachment #8636836 - Flags: review?(dmose)
Status: NEW → ASSIGNED
Comment on attachment 8636836 [details] [diff] [review]
Implement updated design of contact buttons

Review of attachment 8636836 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose, assuming you put this up for ui-review and land it at the same time as the tab footer patch.
Attachment #8636836 - Flags: review?(dmose) → review+
Depends on: 1183636
Rank: 19
Rank: 19 → 17
https://hg.mozilla.org/mozilla-central/rev/7f50f6fe0f3d
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
Iteration: --- → 42.3 - Aug 10
QA Contact: bogdan.maris
Approval Request Comment
[Feature/regressing bug #]: FF Hello Visual Refresh, backout patch 3 of 5
[User impact if declined]: Partial refresh implementation landed for 42, but is now being completed for 43 and isn't suitable for uplift. Hence, the current partially done 42 has bad layouts and an incomplete design change.
[Describe test coverage new/current, TreeHerder]: Code has unit tests
[Risks and why]: Low - reverting to the previous version.
[String/UUID change made/needed]: None. Any string changes were not backed out.
Attachment #8658615 - Flags: approval-mozilla-aurora?
I'm guessing this means no QA verification is needed here anymore.
Flags: qe-verify+
(In reply to Florin Mezei, QA (:FlorinMezei) from comment #16)
> I'm guessing this means no QA verification is needed here anymore.

Its only being backed out of 42, but I'm not sure verification was really needed anyway being almost purely just changing the layout of the UI.
Mark, could you open a new bug for the backout?
Otherwise, this bug is going to be confusing.
Thanks
Flags: needinfo?(standard8)
Comment on attachment 8658615 [details] [diff] [review]
Backout for Aurora (42)

managed in bug 1203454
Flags: needinfo?(standard8)
Attachment #8658615 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
Flags: qe-verify+
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.