1184296 - aborted installation of addon won't install second time

Status: RESOLVED INVALID

(Toolkit :: Add-ons Manager, defect)

Description

[Steven Harris]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/43.0.2357.130 Safari/537.36

Steps to reproduce:

Using FF40B4
1) Initiate install of unlisted addon
2) Click Allow
3) The download eventually completes
4) FF displays the Cancel/Install addon dialog
5) Click outside of the dialog, thus closing the dialog w/out installing the addon
6) Reinitiate the install using the same as #1 above
7) Click Allow
8) The download eventually completes
9) No dialog appears to allow the user to Cancel/Install the just downloaded addon

You can see the issue reproduced here - http://screencast.com/t/X1PCLJ1mx

Of note, if the user clicks on the puzzle piece (ie. addon icon) on the left of the awesome bar, the addon is successfully installed.


Actual results:

In the above steps, it was expected that the dialog that appears at step #4 would also appear at step #9. This did not happen, thus preventing the user from being able to install the addon.

As noted above, clicking on the puzzle piece does work, but it is not expected that the user would know enough to compete the installation of the addon by clicking that icon.


Expected results:

As stated above, the user should have seen the #4 dialog at step #9 to complete the installation of the addon.

Comment 1

[Petruta Horea [:phorea], Desktop QA]

Reproduced with Nightly 42.0a1 under Win 7 64-bit.

Comment 2

[Steven Harris]

I am glad to see you've reproduced this. Do you have any estimates as to when this issue will be addressed?

Comment 3

[Dave Townsend [:mossop]]

Attachment: patch

I think until we have the time to make these notifications sanely work with multiple installs (bug 1171636) we should just assume that if the user dismisses the install notification that they don't want it and cancel the install.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/d192b58f439b

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d192b58f439b

Comment 6

[Vasilica Tamas, QA [:vtamas]]

This fix causes several other issues:

1. Clicking on Learn More link from installation approval doorhanger cancels the install process.
2. Installing 2 consecutive add-ons cancels the first process.
3. The user is not able to add new tabs or to continue the browsing without to cancel the install process.
4. [intermittent] Navigating to a new tab during the download process, the user is pulled back to the add-on tab, but the install process is canceled.
5. The user is not able to navigate to a sub-directory of the current page after the download is completed, without to cancel the install process.

Dave, any thoughts about these issues?

And I think this bug is a duplicate of Bug 1174684.

Comment 7

[Dave Townsend [:mossop]]

Yeah those regressions look serious enough that we should back this out and live with this bug until we can fix bug 1171636

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/23a18ed8ddc5

Comment 9

[Dão Gottwald [:dao]]

The patch seems to have landed before the merge, the backout after the merge, so this will need another backout from aurora.

Comment 10

[Dave Townsend [:mossop]]

Yeah, pulsebot didn't post it for some reason: https://hg.mozilla.org/releases/mozilla-aurora/rev/a695ecb82d4d

Comment 13

[arni2033]

Slightly different STR and result in bug 1202406

Comment 15

[Andy McKay]

I can't recreate the STR because we've redone the install flow with the new doorhangers and permissions. If there's a similar bug, let's refile a bug.