1184377 - Move nsDocShell::PopProfileTimelineMarkers logic to ObservedDocShell

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Comment 1

[Victor Porof [:vporof][:vp]]

This is the last bit that will allow us to make the mTimelineMarkers array private in ObservedDocShell and claim that markers logic is not dependent on nsDocShell anymore.

There's still small bits like NotifyJSRunToCompletionStart, NotifyJSRunToCompletionStop and JavascriptTimelineMarker that exist inside nsDocShell.cpp, but that's just a matter of moving the code somewhere else.

Comment 2

[Victor Porof [:vporof][:vp]]

Attachment: v1

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Annoying to review code move + code refactoring change.
code moves should always happen separately.

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8635522 [details] [diff] [review]
v1

Alright, splitting this up.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8635522 [details] [diff] [review]
v1

I hope I didn't miss anything. Comparing the code move and simultaneously making sure code refactoring is ok really makes this kind of review harder.

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/7c8dd116e583

Comment 7

[Tim Taubert [:ttaubert] (inactive)]

https://hg.mozilla.org/mozilla-central/rev/7c8dd116e583

Comment 8

[Victor Porof [:vporof][:vp]]

This was backed out in: https://hg.mozilla.org/integration/fx-team/rev/fdff9c45b9c9

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/e8f41c5c64fd

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e8f41c5c64fd