1186267 - Add a keyboard shortcut for toggling the tab mute state

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[(no longer active)]

This is a follow-up to bug 486262.  We need to add a keyboard shortcut in order to make this feature accessible.

Comment 1

[Tim Nguyen :ntim]

How about Ctrl/Cmd+Shift+M ?

Comment 2

[:Gijs (he/him)]

(In reply to Tim Nguyen [:ntim] from comment #1)
> How about Ctrl/Cmd+Shift+M ?

Taken by responsive design mode.

Comment 3

[(no longer active)]

We decided to go with Alt/Option+Shift+M.

Comment 4

[(no longer active)]

Attachment: Change the tooltips for the tab audio indicator icon to describe the action taken by clicking the icon

The (%S) in the tooltip strings is a placeholder to be filled in bug 1186267.

I'm going to land both of these patches together, and am adding the placeholder string here to save string churn.

Comment 5

[(no longer active)]

Comment on attachment 8644100 [details] [diff] [review]
Change the tooltips for the tab audio indicator icon to describe the action taken by clicking the icon

Wrong bug!

Comment 6

[(no longer active)]

Attachment: Add a keyboard shortcut for toggling the mute state of a tab

The localization notes are for the strings added in bug 1188114.  I'm adding the notes here since they semantically belong in this change.

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1bf04cb6ea41

Comment 8

[Bob49]

Alt/Option+Shift+M. (or Alt + M identical action !)  inconsistency !

by default for Firefox : Alt calls menu bar + M calls Bookmarks menu !

Thank you not to touch this old shortcut combination, very helpful.

Comment 9

[Bob49]

Besides why ? "option"

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1bf04cb6ea41

Comment 12

[Bob49]

Maj + Alt + M (common sense for Windows)... OK, it works. :)

Comment 13

[(no longer active)]

Bob, please file a follow-up bug if you are asking for changes or reporting an issue, and please include some description of what you mean.  I can't really understand what you mean here.

Comment 14

[Marco Zehe (:MarcoZ)]

CC'ing cmills because he might have some thoughts/ideas, as expressed in a thread on dev-accessibility.

Comment 15

[Chris Mills [:cmills]]

A mute shortcut for the entire browser would also be useful, imo. What if you have a large number of tabs open? Finding the exact tab to mute might be a pain.