1193749 - Use standard modifier keys for the Mute Tab keyboard shortcut

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[jaramat]

Current keyboard shortcut for muting a tab is Alt+Shift+M. While that may be acceptable on Mac or even Linux, Windows and Windows programs rarely use Alt+Shift as a keyboard combo.

Proposed change: Change it to Ctrl+M. Ctrl+M isn't a system-wide shortcut nor is it used internally in Firefox, so it's available. It's also easier to memorize and easier to hit with one hand (Alt+Shift+M is nearly impossible to hit).

Comment 1

[Dão Gottwald [:dao]]

(In reply to jaramat from comment #0)
> Current keyboard shortcut for muting a tab is Alt+Shift+M. While that may be
> acceptable on Mac or even Linux, Windows and Windows programs rarely use
> Alt+Shift as a keyboard combo.

It's similarly odd on Linux as far as I can tell.

Comment 2

[(no longer active)]

If Ctrl+M is free, this is reasonable.  I'll write a patch.

Comment 3

[(no longer active)]

(Note that Cmd+M minimizes the window on OSX, but we can use Ctrl+M there.)

Comment 4

[(no longer active)]

Attachment: Switch the keyboard shortcut to toggle the mute state of a tab to Ctrl+M

Also adding a test since I realized that I didn't do that before for some reason.

Comment 5

[(no longer active)]

Ping?

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8647196 [details] [diff] [review]
Switch the keyboard shortcut to toggle the mute state of a tab to Ctrl+M

Review of attachment 8647196 [details] [diff] [review]:
-----------------------------------------------------------------

Weird, I already reviewed this but must not have hit Publish. Thanks for the ping.

::: browser/base/content/test/general/browser_audioTabIcon.js
@@ +275,5 @@
> +  }
> +  function* test_on_browser(browser) {
> +    let tab = gBrowser.getTabForBrowser(browser);
> +
> +    // Make sure it's possible to mute before the tab is playing.

This is a neat feature and I could see myself maybe using this, but I don't see a way for people to find out about it. Out of curiosity, is there any way to access this feature outside of the keyboard shortcut?

Comment 7

[(no longer active)]

Not currently, no.  I've thought about it, and maybe we should add a context menu entry for muting a tab?

Comment 8

[(no longer active)]

(Note that users have asked for this too, see bug 1193848.)

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6930b12ee1d1

Comment 10

[(no longer active)]

Comment on attachment 8647196 [details] [diff] [review]
Switch the keyboard shortcut to toggle the mute state of a tab to Ctrl+M

Approval Request Comment
[Feature/regressing bug #]: Tab audio indicators
[User impact if declined]: The current keyboard shortcut is hard to use.
[Describe test coverage new/current, TreeHerder]: Has test.
[Risks and why]: Not risky at all
[String/UUID change made/needed]: This doesn't have a string change, but it affects a string shown in the UI (the keyboard shortcut string in the tooltip message.)  Therefore I'd like to take it on Aurora ASAP.  Thanks!

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6930b12ee1d1

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8647196 [details] [diff] [review]
Switch the keyboard shortcut to toggle the mute state of a tab to Ctrl+M

Let's take this patch. We want to polish this feature!

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b44a8c68fc60

Comment 14

[Camelia Badau [:cbadau], Desktop Test Engineering]

Verified fixed using latest Aurora 42.0a2 (buildID: 20150917004025) and latest Nightly 43.0a1 (buildID: 20150917030229).