1187210 - Path2D.arc hang

Status: VERIFIED FIXED

(Core :: Graphics: Canvas2D, defect)

Description

[Jesse Ruderman]

Attachment: testcase (hangs Firefox)

Might be related to bug 943587.

Comment 1

[Lee Salzman [:lsalzman]]

Attachment: limit ArcToBezier sweeps while taking care of floating-point inaccuracy

Due to floating point inaccuracies, large angles would cause the angle correction step to modify aStartAngle and aEndAngle such that arcSweepLeft still resulted in a huge value, much larger than 2*PI, thus causing ArcToBezier to iterate far more than the expected number of times.

Comment 3

[Lee Salzman [:lsalzman]]

Attachment: limit ArcToBezier sweeps while taking care of floating-point inaccuracy

Fix some mochitest issues with reverse sweeps and Skia canvas precision issues.

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=47d0b14e7330

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5a03eaa2db9f

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5a03eaa2db9f

Comment 7

[Mihai Boldan, Desktop QA [:mboldan]]

Reproduced the initial issue on Win 10 x32, Ubuntu 14.04 x32 and Mac OS X 10.11 using Firefox 40.0.2 (20150812163655)build using the attached testcase. Verified that the issues does not reproduce on Firefox 42.0 Beta 4 (20151005144425) on the same environment.