1187542 - Enable new MediaSource architecture on FFOS

Status: RESOLVED FIXED

(Core :: Audio/Video, defect, P2)

Description

[Jean-Yves Avenard [:jya]]

It was disabled in https://hg.mozilla.org/mozilla-central/rev/d3228c82badd

The core issue is a crash in Gonk MediaDataDecoder.

There is an intermittent failure in Android's stagefright ACodec.

Comment 1

[Alfredo Yang (:alfredo)]

Try looks good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=85abeacff27c

Comment 2

[Alfredo Yang (:alfredo)]

Attachment: enable_new_mse_on_gonk

Comment 3

[Jean-Yves Avenard [:jya]]

Comment on attachment 8644278 [details] [diff] [review]
enable_new_mse_on_gonk

Review of attachment 8644278 [details] [diff] [review]:
-----------------------------------------------------------------

Yes ! \o/

Are the MSE mochitest enabled now on gonk?

If not, it would be unwise to enable MSE

Comment 4

[Jean-Yves Avenard [:jya]]

(In reply to Alfredo Yang (:alfredo) from comment #1)
> Try looks good.
> 
> https://treeherder.mozilla.org/#/jobs?repo=try&revision=85abeacff27c

There are no mediasource mochitest running in this try run that I can see.
So being green probably doesn't mean it's good.

Comment 5

[Alfredo Yang (:alfredo)]

(In reply to Jean-Yves Avenard [:jya] from comment #3)
> Comment on attachment 8644278 [details] [diff] [review]
> enable_new_mse_on_gonk
> 
> Review of attachment 8644278 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Yes ! \o/
> 
> Are the MSE mochitest enabled now on gonk?
> 
> If not, it would be unwise to enable MSE

Unfortunately it doesn't. The current gonk PlarformDecodeModule uses MediaCodec which is available after on emulator-kk. However, gonk mochitest only available on emuator-ics.

I'm planning to implement a new PlatformDecodeModule based on OpenMax (IOMX on gonk). That'll solve the porting problem between Android version and enable the mochitest on try.

Comment 6

[Chris Peterson [:cpeterson]]

(In reply to Alfredo Yang (:alfredo) from comment #5)
> Unfortunately it doesn't. The current gonk PlarformDecodeModule uses
> MediaCodec which is available after on emulator-kk. However, gonk mochitest
> only available on emuator-ics.

Alfredo, which gonk mochitests are only available on emulator-ics?

Comment 7

[Alfredo Yang (:alfredo)]

(In reply to Chris Peterson [:cpeterson] from comment #6)
> (In reply to Alfredo Yang (:alfredo) from comment #5)
> > Unfortunately it doesn't. The current gonk PlarformDecodeModule uses
> > MediaCodec which is available after on emulator-kk. However, gonk mochitest
> > only available on emuator-ics.
> 
> Alfredo, which gonk mochitests are only available on emulator-ics?

I may not explain it very well in the last comment.
Allow me to explain it more complete.

The mp4 tests on emulator-ics are using old architecture. FxOS playback before (including) 2.2 uses the old architecture.

From FxOS 2.5, MSE/EME, mp4 playback will use the new PlatformDecodeModule architecture. Unfortunately, the gonk PlatformDecodeModule is based on an Android module which is available after (including) Android-KK.

In short, all MSE/EME, MP4 playback tests on FxOS 2.5 won't be available on try.

To solve this problem, there are 2 ways IMHO:
1. enable emualtor-kk try tests.
2. implement a PlatformDecodeModule which uses OpenMax directly.

Comment 8

[Alfredo Yang (:alfredo)]

(In reply to Jean-Yves Avenard [:jya] from comment #4)
> (In reply to Alfredo Yang (:alfredo) from comment #1)
> > Try looks good.
> > 
> > https://treeherder.mozilla.org/#/jobs?repo=try&revision=85abeacff27c
> 
> There are no mediasource mochitest running in this try run that I can see.
> So being green probably doesn't mean it's good.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=12e11cf83341

Comment 9

[Jean-Yves Avenard [:jya]]

so if there's no test for MSE ; what will the try run show ?

Comment 10

[Alfredo Yang (:alfredo)]

(In reply to Jean-Yves Avenard [:jya] from comment #9)
> so if there's no test for MSE ; what will the try run show ?

It uses a fake deocder, BlankDecoderModule.

Comment 11

[Alfredo Yang (:alfredo)]

Bug 1152236 happens again. :(
I don't think it is MSE problem so I'd prefer to fix it under new architecture.

Comment 12

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bfe67700a88e

Comment 13

[Chris Peterson [:cpeterson]]

Alfredo, thanks for explaining the differences between the FxOS 2.2 and 2.5 tests. Will FxOS 2.5 require Android-KK or later? Will the OpenMax/IOMX PlatformDecoderModule work on 2.2 and replace the MediaCodec PlarformDecodeModule on 2.5?

Comment 14

[Alfredo Yang (:alfredo)]

(In reply to Chris Peterson [:cpeterson] from comment #13)
> Alfredo, thanks for explaining the differences between the FxOS 2.2 and 2.5
> tests. Will FxOS 2.5 require Android-KK or later? Will the OpenMax/IOMX
> PlatformDecoderModule work on 2.2 and replace the MediaCodec
> PlarformDecodeModule on 2.5?

Yes for both questions.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bfe67700a88e