Closed
Bug 1187946
(nexus-5l-builds)
Opened 9 years ago
Closed 9 years ago
Enable Nexus 5L builds in taskcluster
Categories
(Taskcluster :: General, defect)
Taskcluster
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: selenamarie, Assigned: mshal)
References
Details
Attachments
(1 file)
8.30 KB,
patch
|
wcosta
:
review+
|
Details | Diff | Splinter Review |
Move builds for Nexus 5L into Taskcluster.
Reporter | ||
Updated•9 years ago
|
Alias: nexus-5l-builds
Summary: nexus → Enable Nexus 5L builds in taskcluster
Reporter | ||
Comment 1•9 years ago
|
||
Conversation about support: https://groups.google.com/d/msg/mozilla.dev.b2g/qzyR4okRVYI/P3n4oMW9kgUJ
Assignee | ||
Comment 2•9 years ago
|
||
Most of the nexus-4 configuration was already in tree, but not enabled. I fixed it so it builds, and added nexus-5l. I verified on try by temporarily adding it to try/job_flags.yml, though we don't currently seem to build nexus on try so that isn't part of this patch. Is there a way to verify that the builds actually built correctly? ie: that the eng builds are actually eng builds, and/or it actually is a fully functioning nexus build? I don't have a device to test it on.
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=9ed4c64ea786
Assignee: nobody → mshal
Attachment #8662722 -
Flags: review?(wcosta)
Comment 3•9 years ago
|
||
Comment on attachment 8662722 [details] [diff] [review]
0001-Bug-1187946-enable-Nexus-B2G-builds-in-Taskcluster.patch
Review of attachment 8662722 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, you just need to add the phone names to base_job_flags.yml file [1]
[1] https://dxr.mozilla.org/mozilla-central/source/testing/taskcluster/tasks/branches/base_job_flags.yml#8
Attachment #8662722 -
Flags: review?(wcosta) → review+
Assignee | ||
Comment 5•9 years ago
|
||
I updated base_job_flags.yml & also added blobfree for nexus-5l per our IRC conversation. The nexus-4 builds failed with blobfree enabled, so if that's required someone will have to dig into it some more :)
Comment 6•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Comment 7•9 years ago
|
||
That is lacking exposing the blobfree distribution too.
Comment 8•9 years ago
|
||
(In reply to Alexandre LISSY :gerard-majax from comment #7)
> That is lacking exposing the blobfree distribution too.
It's a bug in fact, the present patch was okay :)
You need to log in
before you can comment on or make changes to this bug.
Description
•