Closed
Bug 1206379
Opened 9 years ago
Closed 9 years ago
Nexus 5 L blobfree distribution is not picked up
Categories
(Firefox Build System :: Task Configuration, task)
Firefox Build System
Task Configuration
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla44
People
(Reporter: gerard-majax, Assigned: gerard-majax)
References
Details
(Whiteboard: [systemsfe] [tc-build-support])
Attachments
(1 file, 1 obsolete file)
2.77 KB,
patch
|
gerard-majax
:
review+
|
Details | Diff | Splinter Review |
> testing/taskcluster/scripts/phone-builder/post-build.sh:if [ -f $WORKSPACE/B2G/upload-public/${DEVICE}.blobfree-dist.zip ]; then
We expecte hammerhead.blobfree-dist.zip but I don't know why in this script, we have DEVICE with |nexus| value.
Hence the execution gives:
> if [ -f $WORKSPACE/B2G/upload-public/${DEVICE}.blobfree-dist.zip ]; then
> mv $WORKSPACE/B2G/upload-public/${DEVICE}.blobfree-dist.zip $HOME/artifacts-public
> fi
> ++ '[' -f /home/worker/workspace/B2G/upload-public/nexus.blobfree-dist.zip ']'
Assignee | ||
Comment 1•9 years ago
|
||
Assignee | ||
Comment 2•9 years ago
|
||
Attachment #8663367 -
Flags: review?(wcosta)
Comment 3•9 years ago
|
||
This is because the device name for flame-kk is flame, this patch will break flame-kk builds, iiuc.
Assignee | ||
Comment 4•9 years ago
|
||
(In reply to Wander Lairson Costa [:wcosta] from comment #3)
> This is because the device name for flame-kk is flame, this patch will break
> flame-kk builds, iiuc.
No, it does not break anything: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e4f7de9c69ef
Comment 5•9 years ago
|
||
Comment on attachment 8663367 [details] [diff] [review]
Fix blobfree distribution collect for nexus-5-l
Review of attachment 8663367 [details] [diff] [review]:
-----------------------------------------------------------------
You are right, this only affects blobfree.
Attachment #8663367 -
Flags: review?(wcosta) → review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Whiteboard: [systemsfe]
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8663367 -
Attachment is obsolete: true
Attachment #8664174 -
Flags: review+
Assignee | ||
Updated•9 years ago
|
Keywords: checkin-needed
Assignee | ||
Comment 8•9 years ago
|
||
Works well, except that VARIANT=user build do not boots :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla44
Updated•9 years ago
|
Whiteboard: [systemsfe] → [systemsfe] [tc-build-support]
Updated•9 years ago
|
Component: Generic-Worker → Task Configuration
Updated•7 years ago
|
Product: TaskCluster → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•