1187964 - View source from Thunderbird uses deprecated API

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Ian Neal]

+++ This bug was initially created as a clone of Bug #1187956 +++

Error: DEPRECATION WARNING: The arguments you're passing to viewSource.xul are using an out-of-date API.
You may find more details about this deprecation at: https://developer.mozilla.org/en-US/Add-ons/Code_snippets/View_Source_for_XUL_Applications
chrome://global/content/viewSource.js 316 _loadViewSourceDeprecated
chrome://global/content/viewSource.js 302 onXULLoaded
chrome://global/content/viewSource.js 175 handleEvent
null 0 null

Comment 1

[Ian Neal]

Attachment: Fix-up caller

Simple fix-up of the one caller.

Comment 2

[Ian Neal]

Attachment: Fix-up caller v1.1 [Checked in: Comment 6]

Carried across from work in Bug 1187956, new API needs to have browser and outerWindowID arguments to even consider using a different characterset.

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 8641050 [details] [diff] [review]
Fix-up caller v1.1 [Checked in: Comment 6]

Review of attachment 8641050 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, thx! r=mkmelin

Comment 4

[:aceman]

(In reply to Ian Neal from comment #2)
> Created attachment 8641050 [details] [diff] [review]
> Fix-up caller v1.1
> 
> Carried across from work in Bug 1187956, new API needs to have browser and
> outerWindowID arguments to even consider using a different characterset.

But in the latest patch you removed setting characterset. Will it be somehow inferred automatically? Or is it no longer needed?

Comment 5

[Ian Neal]

(In reply to :aceman from comment #4)
> (In reply to Ian Neal from comment #2)
> > Created attachment 8641050 [details] [diff] [review]
> > Fix-up caller v1.1
> > 
> > Carried across from work in Bug 1187956, new API needs to have browser and
> > outerWindowID arguments to even consider using a different characterset.
> 
> But in the latest patch you removed setting characterset. Will it be somehow
> inferred automatically? Or is it no longer needed?

I believe the new API pulls the characterset from the browser object passed in the arguments. Either way the new API doesn't allow for a characterset to be passed as an argument.

Comment 6

[Ian Neal]

Comment on attachment 8641050 [details] [diff] [review]
Fix-up caller v1.1 [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/24c721056762