Closed Bug 1188544 Opened 4 years ago Closed 4 years ago

[Dialer][NGA] Remove navigation based on hashchange

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(blocking-b2g:2.5+, b2g-master fixed)

RESOLVED FIXED
FxOS-S4 (07Aug)
blocking-b2g 2.5+
Tracking Status
b2g-master --- fixed

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file)

In order to apply all changes in Contacts based on NGA, we need to get rid of the hashchange navigation (due to Contacts will navigate itself).

This is the first step in order to have an isolated Contacts App in the near future.
Assignee: nobody → borja.bugzilla
Comment on attachment 8640019 [details] [review]
[gaia] borjasalguero:dialer_navigation > mozilla-b2g:master

Francisco, this is a first approach. Could you take a look? Thanks!
Attachment #8640019 - Flags: feedback?(francisco)
Comment on attachment 8640019 [details] [review]
[gaia] borjasalguero:dialer_navigation > mozilla-b2g:master

Hei Borja,

could you ping Gabriele for feedback here?
Attachment #8640019 - Flags: feedback?(francisco)
Comment on attachment 8640019 [details] [review]
[gaia] borjasalguero:dialer_navigation > mozilla-b2g:master

As the NGA work is based on changes in location (no <iframes> or wrapper needed, just navigate as the web does), the navigation model in Dialer must change slightly in order to avoid collision with Contacts NGA.

Based on that, we are going to remove the navigation based in 'hashchange' due to this affects the navigation within the Contacts iframe (<iframe> and wrapper share the history, so any change in Contacts history affects the history in the Dialer).

In the near future Contacts will be out of Dialer, so we will revisit this once Dialer will use NGA proposal.

Gabriele, Could you take a look? This is blocking some other bugs related with NGA. Thanks!
Attachment #8640019 - Flags: review?(gsvelto)
Blocks: 1183727, 1183728
[Blocking Requested - why for this release]:
According to comment 4, and despite that we want to remove contacts from dialer in 2.5, we will need to have a solution before contacts is able to land their multiple documents solution. As dialer wont work while we have separated documents.
blocking-b2g: --- → 2.5?
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S4 (07Aug)
Comment on attachment 8640019 [details] [review]
[gaia] borjasalguero:dialer_navigation > mozilla-b2g:master

This looks quite good in general, there's only one small thing I'd like to see addressed in the Navigation object (comment in the PR) and then I think we're good to land.
Attachment #8640019 - Flags: review?(gsvelto) → feedback+
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Comms triage: Needed for the split between Dialer and Contacts.
blocking-b2g: 2.5? → 2.5+
Comment on attachment 8640019 [details] [review]
[gaia] borjasalguero:dialer_navigation > mozilla-b2g:master

Hi Gabriele! I've update the patch with your suggestions, could you take a look? Thanks!
Attachment #8640019 - Flags: review?(gsvelto)
Comment on attachment 8640019 [details] [review]
[gaia] borjasalguero:dialer_navigation > mozilla-b2g:master

Looks good to me and I couldn't find any problem while testing, time to land!

http://shipitsquirrel.github.io/
Attachment #8640019 - Flags: review?(gsvelto) → review+
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Depends on: 1198361
You need to log in before you can comment on or make changes to this bug.