Closed Bug 1183727 Opened 4 years ago Closed 4 years ago

[Contacts][NGA] Create #update view and connect it to #open within Contacts App

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S5 (21Aug)
Tracking Status
b2g-master --- fixed

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(1 file, 4 obsolete files)

Connect #open & #update within the app, so #update is available to be called from the list when calling 'update' in the activity.
Assignee: nobody → borja.bugzilla
Blocks: 1175471
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S3 (24Jul)
Status: NEW → ASSIGNED
Attached file Pull Request (obsolete) —
This patch is adding #update view, and connect this view with #open.

There is no navigation in this patch (will be added in a separate patch), and it needs all changes in Gecko about pre-render and Back&Forward Cache (we need to increase the memory from 1 element to 5 as we agreed in Whistler).

However this is really exciting, due to the app just use the code it needs! Could you take a look? Thanks!
Attachment #8634169 - Flags: feedback?(francisco)
Attachment #8634169 - Flags: feedback?(francisco)
Attachment #8634167 - Flags: feedback?(francisco)
Attachment #8634167 - Flags: feedback?(b.mcb)
Comment on attachment 8634167 [details] [review]
[gaia] borjasalguero:update > mozilla-b2g:master

First good approach, just left some comments on gh.
Attachment #8634167 - Flags: feedback?(francisco)
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Depends on: 1184953
Target Milestone: FxOS-S3 (24Jul) → FxOS-S4 (07Aug)
Depends on: 1188544
Attachment #8634167 - Flags: feedback?(b.mcb)
Depends on: 1183728
Comment on attachment 8634167 [details] [review]
[gaia] borjasalguero:update > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/30983
Attachment #8634167 - Attachment is obsolete: true
Attachment #8634169 - Attachment is obsolete: true
Attachment #8642934 - Flags: review?(francisco)
Attachment #8642934 - Flags: review?(b.mcb)
Comment on attachment 8642934 [details] [review]
[gaia] borjasalguero:update_rebased > mozilla-b2g:master

r+ once comments on gh addressed (mainly ni)

We should provide another pr to increase the number of pages in BF cache depending on device and memory.
Perhaps Vivien can help here.
Flags: needinfo?(21)
Attachment #8642934 - Flags: review?(francisco) → review+
Target Milestone: FxOS-S4 (07Aug) → FxOS-S5 (21Aug)
Attachment #8642934 - Flags: review?(b.mcb)
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Backed out for causing frequent Gij failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=2501406&repo=b2g-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=2502052&repo=b2g-inbound

Master: https://github.com/mozilla-b2g/gaia/commit/95273476d9b3a710c807768a29ff3db301952b57

Also, in the future, please include a link to the Github commit when you push.
Status: RESOLVED → REOPENED
Flags: needinfo?(borja.bugzilla)
Resolution: FIXED → ---
Ryan, treeherder execution[1] for this patch is not showing any error. Could you detail which tests are failing? If I execute locally I have no errors either, so I don't know how to reproduce the same (probably something related with treeherder?). Thanks!


[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1c60d65b4a65ae09eb2c3a965315fdb0acdbc0a8
Flags: needinfo?(borja.bugzilla) → needinfo?(ryanvm)
They were on b2g-inbound, per the log links I gave you. I'm afraid I'm not in a position to help you sort out why they're hitting failures on b-i and not Gaia. Other than to say they were intermittent, not permanent.
Flags: needinfo?(ryanvm)
Merged again after reviewing the tests.

https://github.com/mozilla-b2g/gaia/commit/81ea72db6f1777a2e2022eba27cf2f5e165d8241
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Francisco, could you help us with this? Treeherder was green for this patch [1], and not in inbound. Is there any issue with b2g-inbound?

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=af055b75c3b8f59ba144caad1cc0c353bee9dba4
Flags: needinfo?(21) → needinfo?(francisco)
We need to do more testing when landing this bug.

ie: bug 1193700 the confirm dialog won't work on the details view.
Flags: needinfo?(francisco)
See Also: → 1193700
Attachment #8646264 - Attachment is obsolete: true
Comment on attachment 8648719 [details] [review]
[gaia] borjasalguero:update_selfcontained_rebased > mozilla-b2g:master

Let's wait until we are sure to land this, so asking to review this again.
Attachment #8648719 - Flags: review?(francisco)
Attachment #8642934 - Attachment is obsolete: true
Comment on attachment 8648719 [details] [review]
[gaia] borjasalguero:update_selfcontained_rebased > mozilla-b2g:master

All problems addressed.

Fantastic job here.

Also treeherder looking good, with some repetitions of the jobs that were causing intermitents:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=a1916008434c874f2705fe854d41234fa14db63c
Attachment #8648719 - Flags: review?(francisco) → review+
Merged

https://github.com/mozilla-b2g/gaia/commit/b57de4c493b611dc70c27c7d78445fcb04b1491c
Status: REOPENED → RESOLVED
Closed: 4 years ago4 years ago
Resolution: --- → FIXED
Depends on: 1196893
Depends on: 1196954
Depends on: 1196830
Depends on: 1197750
Depends on: 1201052
Depends on: 1202217
Depends on: 1200459
Depends on: 1203063
You need to log in before you can comment on or make changes to this bug.