1183727 - [Contacts][NGA] Create #update view and connect it to #open within Contacts App

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Description

[Borja Salguero [:borjasalguero]]

Connect #open & #update within the app, so #update is available to be called from the list when calling 'update' in the activity.

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:update > mozilla-b2g:master

Comment 2

[Borja Salguero [:borjasalguero]]

Attachment: Pull Request

This patch is adding #update view, and connect this view with #open.

There is no navigation in this patch (will be added in a separate patch), and it needs all changes in Gecko about pre-render and Back&Forward Cache (we need to increase the memory from 1 element to 5 as we agreed in Whistler).

However this is really exciting, due to the app just use the code it needs! Could you take a look? Thanks!

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8634167 [details] [review]
[gaia] borjasalguero:update > mozilla-b2g:master

First good approach, just left some comments on gh.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:update_rebased > mozilla-b2g:master

Comment 5

[Borja Salguero [:borjasalguero]]

Comment on attachment 8634167 [details] [review]
[gaia] borjasalguero:update > mozilla-b2g:master

>https://github.com/mozilla-b2g/gaia/pull/30983

Comment 6

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8642934 [details] [review]
[gaia] borjasalguero:update_rebased > mozilla-b2g:master

r+ once comments on gh addressed (mainly ni)

We should provide another pr to increase the number of pages in BF cache depending on device and memory.
Perhaps Vivien can help here.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Backed out for causing frequent Gij failures.
https://treeherder.mozilla.org/logviewer.html#?job_id=2501406&repo=b2g-inbound
https://treeherder.mozilla.org/logviewer.html#?job_id=2502052&repo=b2g-inbound

Master: https://github.com/mozilla-b2g/gaia/commit/95273476d9b3a710c807768a29ff3db301952b57

Also, in the future, please include a link to the Github commit when you push.

Comment 8

[Borja Salguero [:borjasalguero]]

Ryan, treeherder execution[1] for this patch is not showing any error. Could you detail which tests are failing? If I execute locally I have no errors either, so I don't know how to reproduce the same (probably something related with treeherder?). Thanks!


[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=1c60d65b4a65ae09eb2c3a965315fdb0acdbc0a8

Comment 9

[Ryan VanderMeulen [:RyanVM]]

They were on b2g-inbound, per the log links I gave you. I'm afraid I'm not in a position to help you sort out why they're hitting failures on b-i and not Gaia. Other than to say they were intermittent, not permanent.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:update_selfcontained > mozilla-b2g:master

Comment 11

[Borja Salguero [:borjasalguero]]

Merged again after reviewing the tests.

https://github.com/mozilla-b2g/gaia/commit/81ea72db6f1777a2e2022eba27cf2f5e165d8241

Comment 12

[Ryan VanderMeulen [:RyanVM]]

Still hitting intermittent issues.
https://treeherder.mozilla.org/logviewer.html#?job_id=2510565&repo=b2g-inbound

Reverted:
Master: https://github.com/mozilla-b2g/gaia/commit/c7875bbc8b32e7b95cc55c9690b03b140905d84d

Comment 13

[Borja Salguero [:borjasalguero]]

Francisco, could you help us with this? Treeherder was green for this patch [1], and not in inbound. Is there any issue with b2g-inbound?

[1] https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=af055b75c3b8f59ba144caad1cc0c353bee9dba4

Comment 14

[Francisco Jordano [:arcturus] [:francisco]]

We need to do more testing when landing this bug.

ie: bug 1193700 the confirm dialog won't work on the details view.

Comment 15

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:update_selfcontained_rebased > mozilla-b2g:master

Comment 16

[Borja Salguero [:borjasalguero]]

Comment on attachment 8648719 [details] [review]
[gaia] borjasalguero:update_selfcontained_rebased > mozilla-b2g:master

Let's wait until we are sure to land this, so asking to review this again.

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8648719 [details] [review]
[gaia] borjasalguero:update_selfcontained_rebased > mozilla-b2g:master

All problems addressed.

Fantastic job here.

Also treeherder looking good, with some repetitions of the jobs that were causing intermitents:

https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=a1916008434c874f2705fe854d41234fa14db63c

Comment 18

[Borja Salguero [:borjasalguero]]

Merged

https://github.com/mozilla-b2g/gaia/commit/b57de4c493b611dc70c27c7d78445fcb04b1491c