1183728 - [Contacts][NGA] Connect #new self-contained view to the app.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:new > mozilla-b2g:master

Comment 2

[Manuel Casas Barrado [:mancas]]

Comment on attachment 8634190 [details] [review]
[gaia] borjasalguero:new > mozilla-b2g:master

Looks great and works fine on my device!

Good job =)

Comment 3

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 8634190 [details] [review]
[gaia] borjasalguero:new > mozilla-b2g:master

Once addressed the nits and added the workaround to recover the theme:

var meta = document.querySelector('meta[name="theme-color"]');
    document.head.removeChild(meta);
    meta = document.createElement('meta');
    meta.content = 'var(--header-background)';
    meta.name = 'theme-color';
    document.head.appendChild(meta);

this is looking awesome!

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] borjasalguero:update_rebased > mozilla-b2g:master