Closed Bug 1183728 Opened 5 years ago Closed 5 years ago

[Contacts][NGA] Connect #new self-contained view to the app.

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S4 (07Aug)
Tracking Status
b2g-master --- fixed

People

(Reporter: borjasalguero, Assigned: borjasalguero)

References

Details

(Whiteboard: [NG Gaia Contacts][patch])

Attachments

(2 files)

No description provided.
Blocks: 1169579
Assignee: nobody → borja.bugzilla
Whiteboard: [NG Gaia Contacts]
Target Milestone: --- → FxOS-S3 (24Jul)
Status: NEW → ASSIGNED
Whiteboard: [NG Gaia Contacts] → [NG Gaia Contacts][patch]
Depends on: 1182509
Target Milestone: FxOS-S3 (24Jul) → FxOS-S4 (07Aug)
Depends on: 1188544
Depends on: 1189203
Blocks: 1189203
No longer depends on: 1189203
Attachment #8634190 - Flags: review?(francisco)
Attachment #8634190 - Flags: review?(b.mcb)
Comment on attachment 8634190 [details] [review]
[gaia] borjasalguero:new > mozilla-b2g:master

Looks great and works fine on my device!

Good job =)
Attachment #8634190 - Flags: review?(b.mcb) → review+
Comment on attachment 8634190 [details] [review]
[gaia] borjasalguero:new > mozilla-b2g:master

Once addressed the nits and added the workaround to recover the theme:

var meta = document.querySelector('meta[name="theme-color"]');
    document.head.removeChild(meta);
    meta = document.createElement('meta');
    meta.content = 'var(--header-background)';
    meta.name = 'theme-color';
    document.head.appendChild(meta);

this is looking awesome!
Attachment #8634190 - Flags: review?(francisco) → review+
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Depends on: 1191471
Depends on: 1191723
You need to log in before you can comment on or make changes to this bug.