1188871 - Loading a page with media content on podiobooks.com hangs indefinitely

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect)

Description

[Jan Henning [:JanH]]

If I try loading a page with media content on podiobooks.com, e.g. http://podiobooks.com/title/a-coffee-crusade/, page loading hangs indefinitely, i.e. the progress bar progresses to approximately 80 %, but then never goes further.

In case it's a device specific bug, I'm using a Samsung Galaxy S3 Mini with the default Android 4.1.2.

Regression window is this one:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=41fd23011c72&tochange=47193134162b

Comment 1

[Jean-Yves Avenard [:jya]]

Snorp, can you reproduce it ? any chance in providing a useful backtrace?

Comment 2

[Jean-Yves Avenard [:jya]]

Jan, are you able to compile Firefox yourself?

Comment 3

[Jan Henning [:JanH]]

Unfortunately not, I'm on Windows.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

I can reproduce this. Backtrace isn't very useful -- every thread is just waiting. Seems like maybe some state management has gone south?

Comment 5

[Jean-Yves Avenard [:jya]]

do you still have the issue with today's Nightly?

I would have thought it was all related to bug 1188870

Comment 6

[Jan Henning [:JanH]]

No, they're only related insofar as I've encountered both bugs on the same page, and of course the crashes from bug 1188870 would have masked any further issues.
Now that those have been fixed, I'm seeing the hanging page loads again.

Comment 7

[Jean-Yves Avenard [:jya]]

I can't make sense of the regression window you've provided. There's nothing there that could prevent a page loading as it's not using MSE.

The only change related to media playback is the draining part which has been reverted in this try run:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=798564c09833

is that something you could try?

Comment 8

[Jan Henning [:JanH]]

Unfortunately, page load is still hanging on that try build.
I've also double-checked the regression range, but with the same result as before.

Comment 9

[Jean-Yves Avenard [:jya]]

I have received my android device today, will be able to test myself.

What steps are you taking to come up with this regression range?

Comment 10

[Jan Henning [:JanH]]

I run mozregression with this arguments:
> mozregression --app fennec --good=2015-07-16 --bad=2015-07-17

Then, once the Nightly has started up, I simply load http://podiobooks.com/title/a-coffee-crusade/.
If page loading completes, i.e. the progress bar runs to completion and then disappears, I declare the build "good". If on the other hand, after a minute or so, page loading is still stuck at around 80 %, I declare the build "bad".

With the above regression range, the first inbound build mozregression tries should be "good", while the next one for me is already "bad".

Comment 11

[Jean-Yves Avenard [:jya]]

thanks.

Can reproduce the issue on a Sony Xperia z3c, with Android 5.1 ; so it's not just your device.

Will work on this tomorrow.

Comment 12

[Jean-Yves Avenard [:jya]]

I woke up with an idea, and I'm fairly certain that's what the problem is.

In bug 1173657, I changed so should any discontinuity occurs (that includes an error) we then drain the decoder and wait for the DrainComplete message to get back.

Looking at the Android Decoder, when an error occurs, it exists its decode event loop.
The decode event loop is what handles the DrainComplete() message so it will never be fired and the reader will be waiting forever.

Comment 13

[Jean-Yves Avenard [:jya]]

ok, that was it.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=82c77396c73f

Comment 14

[Jean-Yves Avenard [:jya]]

Attachment: P2. Call DrainComplete should a decoder occurs while draining.

Part 1 prevented draining when an error occurred. This handles the case where an error occurs during draining.

Comment 15

[Jean-Yves Avenard [:jya]]

Attachment: P1. Don't drain decoders when an error is encountered.

Comment 16

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8647248 [details] [diff] [review]
P2. Call DrainComplete should a decoder occurs while draining.

Review of attachment 8647248 [details] [diff] [review]:
-----------------------------------------------------------------

Another good catch, thanks!

Comment 17

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/914e5f9795c9
https://hg.mozilla.org/integration/mozilla-inbound/rev/cef6a397f50b

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/914e5f9795c9
https://hg.mozilla.org/mozilla-central/rev/cef6a397f50b

Comment 19

[Jan Henning [:JanH]]

Verified as fixed on Nightly (20150815030208).

Comment 20

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/ac6d673c6fd3
https://hg.mozilla.org/releases/mozilla-aurora/rev/0439f40dddbe

Comment 21

[Ralph Giles (:rillian)]

Backed out for a youtube playback regression. See Bug 1199573.
https://hg.mozilla.org/releases/mozilla-aurora/rev/5bb661db5c6c

Comment 22

[Ralph Giles (:rillian)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f0d454030d3d
https://hg.mozilla.org/releases/mozilla-aurora/rev/d710215ba3d5