1189138 - Video corruption when seeking backward on YouTube

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Jean-Yves Avenard [:jya]]

From bug 1180935 comment 29.

Bug 1180935 seems related, however as I couldn't reproduce their issue except when following very particular steps, it is probably different, so filling another bug.

STR:
1. Open https://www.youtube.com/watch?v=8uaoBTBofto
2. Let it play to the end.
3. In the settings, set quality to 360p
4. Press the replay icon.
5. If playback doesn't restart, then press play again after the image has settled.

Video playback will appear frozen, and suddenly restart with corruption.

Probably seeking that is wrong after the sourcebuffer is cleared (which is what YouTube does when forcing a resolution)

Comment 1

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] P1. Only seek to a position if the trackbuffer contains it.

Ignoring the time if it was 0 was a remnant on when Reset() used to call seek and meant to get to the first frame available.
This is no longer relevant, DoSeek is only called when we are explicitly seeking.

Comment 2

[Jean-Yves Avenard [:jya]]

Attachment: P2. Add useful debugging information to logs.

Comment 3

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] P3. Properly shift our demuxing index when data is added.

Should frames be added before our current demuxing position, we must shift the index ; otherwise the next retrieved frames will be the wrong one.

Comment 4

[Jean-Yves Avenard [:jya]]

Attachment: [MSE] P4. Tell the mediasource demuxer of modified range as early as possible.

We would only tell our demuxer once a complete media segment had been received.
A partial media append would have unnecessarily delayed pending seeks.

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/e35038771f2e
https://hg.mozilla.org/integration/mozilla-inbound/rev/e4ea0d56fcb6
https://hg.mozilla.org/integration/mozilla-inbound/rev/ca2c0a7b3b3b
https://hg.mozilla.org/integration/mozilla-inbound/rev/42a673cd36ff

Comment 6

[Carsten Book [:Tomcat]]

backed out part 3 for test failures like https://treeherder.mozilla.org/logviewer.html#?job_id=12289298&repo=mozilla-inbound

Comment 7

[Pulsebot]

Backout:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bce7955eaa13

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3d5c585fa1e3

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e35038771f2e
https://hg.mozilla.org/mozilla-central/rev/e4ea0d56fcb6
https://hg.mozilla.org/mozilla-central/rev/42a673cd36ff
https://hg.mozilla.org/mozilla-central/rev/3d5c585fa1e3