1189686 - "Harness status: Timeout" when running "clients-matchall-client-types.https.html" test

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Noemí Freire (:noemi)]

Test run such as |./mach web-platform-tests _mozilla/service-workers/service-worker/clients-matchall-client-types.https.html|

Actual Result:
Harness status: Timeout
Found 1 tests
1 Timeout
* Verify matchAll() with various client types -> timed out

Traces: https://pastebin.mozilla.org/8838604

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: MozReview Request: Bug 1189686 - Disable unsupported sections. r?catalinb

Bug 1189686 - Disable unsupported sections. r?catalinb

This makes sure the test does not timeout. Due to the way the test is written,
failures are reported on the console rather than immediately failing the test,
which was leading to the timeouts. I have commented in Bug 1130685 to re-enable
these.

Update web-platform-tests expected data

Comment 2

[Cătălin Badea (:catalinb)]

Comment on attachment 8659597 [details]
MozReview Request: Bug 1189686 - Disable unsupported sections. r?catalinb

https://reviewboard.mozilla.org/r/18981/#review16847

Comment 3

[Noemí Freire (:noemi)]

Patch provided by Nikhil so assigning this to him. Please feel free to change it as needed. Thanks!

Comment 4

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7ea3081952ef6ec1ac26824454a444fe8bd1b6d5
Bug 1189686 - Disable unsupported sections. r=catalinb

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7ea3081952ef

Comment 6

[Noemí Freire (:noemi)]

Hi,

just checked in  m-c (c69e31de9aec revision) and the test successfully runs. Thanks for fixing it!.

Summary

Harness status: OK

Found 1 tests
1 Pass
Details
Result	Test Name
Pass	Verify matchAll() with various client types

Comment 7

[Boris Zbarsky [:bzbarsky]]

Wait.  Why are we randomly disabling upstream tests due to our failures?  wpt tests can be annotated as "this test fails by timing out", no?  This patch was not OK, should never have landed, and I'd appreciate it if we didn't r+ any more patches like this, ever...

Comment 8

[Cătălin Badea (:catalinb)]

Yes, this was a bad idea. I guess we were planning on fixing bug 1130685 sooner.