1189714 - use python logging instead of mozlog

Status: RESOLVED FIXED

(Testing :: Talos, defect)

Description

[Julien Pagès (:parkouss)]

We should update to latest mozlog. Note that compatibility is broken between mozlog 2/ 3 for talos usage.

Comment 1

[Julien Pagès (:parkouss)]

We discussed that with jmaher, and we decided to not use mozlog. We use log in a unstructured way, ie like the common logging module so this is good enough.

Comment 2

[Julien Pagès (:parkouss)]

Attachment: 1189714.patch

This should be applied on top of the patch in bug 1190268.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8642548 [details] [diff] [review]
1189714.patch

Review of attachment 8642548 [details] [diff] [review]:
-----------------------------------------------------------------

this seems pretty straightforward.  Lets ensure we test with all the platforms and test jobs!

::: talos/output.py
@@ +138,5 @@
>      @classmethod
>      def CanvasMark_Metric(cls, val_list):
>          """CanvasMark benchmark score (NOTE: this is identical to JS_Metric)"""
>          results = [i for i, j in val_list]
> +        logging.info("CanvasMark benchmark")

I would be fine removing these logging.info statement for the specific metric functions.

Comment 4

[Julien Pagès (:parkouss)]

Pushed to try:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=91e4528745df

Comment 5

[Julien Pagès (:parkouss)]

All green, landed in https://hg.mozilla.org/build/talos/rev/b6589aef27a5.