Closed Bug 1189714 Opened 10 years ago Closed 10 years ago

use python logging instead of mozlog

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: parkouss, Assigned: parkouss)

References

Details

Attachments

(1 file)

We should update to latest mozlog. Note that compatibility is broken between mozlog 2/ 3 for talos usage.
Depends on: 1189720
We discussed that with jmaher, and we decided to not use mozlog. We use log in a unstructured way, ie like the common logging module so this is good enough.
No longer depends on: 1189720
Summary: update mozlog dependency to 3.0 → use python logging instead of mozlog
Attached patch 1189714.patchSplinter Review
This should be applied on top of the patch in bug 1190268.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8642548 - Flags: review?(jmaher)
Comment on attachment 8642548 [details] [diff] [review] 1189714.patch Review of attachment 8642548 [details] [diff] [review]: ----------------------------------------------------------------- this seems pretty straightforward. Lets ensure we test with all the platforms and test jobs! ::: talos/output.py @@ +138,5 @@ > @classmethod > def CanvasMark_Metric(cls, val_list): > """CanvasMark benchmark score (NOTE: this is identical to JS_Metric)""" > results = [i for i, j in val_list] > + logging.info("CanvasMark benchmark") I would be fine removing these logging.info statement for the specific metric functions.
Attachment #8642548 - Flags: review?(jmaher) → review+
Blocks: 1190907
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Depends on: 1192367
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: