Closed
Bug 1189714
Opened 10 years ago
Closed 10 years ago
use python logging instead of mozlog
Categories
(Testing :: Talos, defect)
Testing
Talos
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: parkouss, Assigned: parkouss)
References
Details
Attachments
(1 file)
27.50 KB,
patch
|
jmaher
:
review+
|
Details | Diff | Splinter Review |
We should update to latest mozlog. Note that compatibility is broken between mozlog 2/ 3 for talos usage.
Assignee | ||
Comment 1•10 years ago
|
||
We discussed that with jmaher, and we decided to not use mozlog. We use log in a unstructured way, ie like the common logging module so this is good enough.
No longer depends on: 1189720
Summary: update mozlog dependency to 3.0 → use python logging instead of mozlog
Assignee | ||
Comment 2•10 years ago
|
||
This should be applied on top of the patch in bug 1190268.
Comment 3•10 years ago
|
||
Comment on attachment 8642548 [details] [diff] [review]
1189714.patch
Review of attachment 8642548 [details] [diff] [review]:
-----------------------------------------------------------------
this seems pretty straightforward. Lets ensure we test with all the platforms and test jobs!
::: talos/output.py
@@ +138,5 @@
> @classmethod
> def CanvasMark_Metric(cls, val_list):
> """CanvasMark benchmark score (NOTE: this is identical to JS_Metric)"""
> results = [i for i, j in val_list]
> + logging.info("CanvasMark benchmark")
I would be fine removing these logging.info statement for the specific metric functions.
Attachment #8642548 -
Flags: review?(jmaher) → review+
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
All green, landed in https://hg.mozilla.org/build/talos/rev/b6589aef27a5.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•