Closed Bug 1190265 Opened 9 years ago Closed 9 years ago

update talos to use latest mozbase dependencies

Categories

(Testing :: Talos, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: parkouss, Assigned: parkouss)

References

Details

Attachments

(1 file)

We should use newer mozprocess into talos. It should not change anything - but some important changes in process output handling were made into mozprocess 0.22, so eventually this could lead to regressions, or bug fixes (relative to the "5 seconds required sleep after process" for example).
See Also: → 1190268
Now that we resolved the logging stuff, I thing we should try to update to every latest dependency in one go. Else we are going into troubles because of mozlog 3.0 compatibility issue with older versions.
Summary: update mozprocess dependency to 0.22 → update talos to use latest mozbase dependency
Blocks: 1190907
Summary: update talos to use latest mozbase dependency → update talos to use latest mozbase dependencies
Oh, and here is the patch. This updates every mozbase dependencies to latests - available on internal pypi, really similar to public pypi. Also this do not enforce versions. Since we are going to use in tree stuff, this is not a bad idea I think.
Assignee: nobody → j.parkouss
Status: NEW → ASSIGNED
Attachment #8644457 - Flags: review?(jmaher)
All green! --10 times now, but I think we are good.
Yay, everything is just green! We should land that right now. :)
I am concerned about the windows pgo stuff, that is where we had problems before, although I suspect it won't be as much of a problem. I say we get this in and land on inbound asap, then we can backout if needed.
Comment on attachment 8644457 [details] [diff] [review] update_mozbase_deps.patch Review of attachment 8644457 [details] [diff] [review]: ----------------------------------------------------------------- much cleaner.
Attachment #8644457 - Flags: review?(jmaher) → review+
Hmm, on PGO build, dromaeo win7 is failing every time.
yeah, we disabled dromaeo_dom in general because it fails in win7 e10s pgo all the time. That test is just problematic and if it is a single test causing problems in a variety of environments, the problem is the test :) This is the test which caused problems before.
Thanks for the explanation! Landed in https://hg.mozilla.org/build/talos/rev/6e62b920e8d8.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: