Closed
Bug 1190440
Opened 9 years ago
Closed 9 years ago
Add React license to about:license for latest versions of React
Categories
(Hello (Loop) :: Client, defect, P2)
Hello (Loop)
Client
Tracking
(firefox41 fixed, firefox42 fixed)
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(1 file)
3.50 KB,
patch
|
gerv
:
review+
ritu
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
Per bug 1185704, we need to add the license to about:license to cover the latest versions of React that we're using.
Moving here so that we can use tracking flags, as I want to uplift to Aurora so that we can get it out as soon as is reasonable.
Assignee | ||
Comment 1•9 years ago
|
||
As per bug 1185704, adding the react license to about:license.
Copied & pasted from the LICENSE file here: https://github.com/facebook/react
Attachment #8642462 -
Flags: review?(gerv)
Assignee | ||
Updated•9 years ago
|
Iteration: --- → 42.3 - Aug 10
Points: --- → 1
Flags: firefox-backlog+
Target Milestone: --- → mozilla42
Comment 2•9 years ago
|
||
Comment on attachment 8642462 [details] [diff] [review]
Add React License for latest versions of React.
Review of attachment 8642462 [details] [diff] [review]:
-----------------------------------------------------------------
r=gerv.
Gerv
Attachment #8642462 -
Flags: review?(gerv) → review+
Updated•9 years ago
|
Rank: 25
Priority: -- → P2
Assignee | ||
Comment 4•9 years ago
|
||
Comment on attachment 8642462 [details] [diff] [review]
Add React License for latest versions of React.
Approval Request Comment
[Feature/regressing bug #]: bug 1096399
[User impact if declined]: None - licensing fix
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: Low. Updates about:license to include a license for a change that was made in Fx37 when we upgraded the library but missed the license change. Suggesting uplift so that we correct it as soon as reasonably possible.
[String/UUID change made/needed]: None
Attachment #8642462 -
Flags: approval-mozilla-aurora?
Comment 5•9 years ago
|
||
Mark, does any changes to licensing info have a l10n impact? Or are these always English only? Thanks.
Flags: needinfo?(standard8)
Assignee | ||
Comment 7•9 years ago
|
||
(In reply to Ritu Kothari (:ritu) from comment #6)
> Mark, does any changes to licensing info have a l10n impact? Or are these
> always English only? Thanks.
Its English-only, there's no localisation going on here.
Flags: needinfo?(standard8)
status-firefox41:
--- → affected
Comment on attachment 8642462 [details] [diff] [review]
Add React License for latest versions of React.
[Triage Comment]
Licensing related low-risk change, should be safe to uplift to Beta41
Attachment #8642462 -
Flags: approval-mozilla-aurora? → approval-mozilla-beta+
Assignee | ||
Comment 9•9 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•