Add React license to about:license for latest versions of React

RESOLVED FIXED in Firefox 41

Status

defect
P2
normal
Rank:
25
RESOLVED FIXED
4 years ago
4 months ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
mozilla42
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +

Firefox Tracking Flags

(firefox41 fixed, firefox42 fixed)

Details

Attachments

(1 attachment)

Per bug 1185704, we need to add the license to about:license to cover the latest versions of React that we're using.

Moving here so that we can use tracking flags, as I want to uplift to Aurora so that we can get it out as soon as is reasonable.
As per bug 1185704, adding the react license to about:license.

Copied & pasted from the LICENSE file here: https://github.com/facebook/react
Attachment #8642462 - Flags: review?(gerv)
Iteration: --- → 42.3 - Aug 10
Points: --- → 1
Flags: firefox-backlog+
Target Milestone: --- → mozilla42
Comment on attachment 8642462 [details] [diff] [review]
Add React License for latest versions of React.

Review of attachment 8642462 [details] [diff] [review]:
-----------------------------------------------------------------

r=gerv.

Gerv
Attachment #8642462 - Flags: review?(gerv) → review+
Rank: 25
Priority: -- → P2
Comment on attachment 8642462 [details] [diff] [review]
Add React License for latest versions of React.

Approval Request Comment
[Feature/regressing bug #]: bug 1096399
[User impact if declined]: None - licensing fix
[Describe test coverage new/current, TreeHerder]: N/A
[Risks and why]: Low. Updates about:license to include a license for a change that was made in Fx37 when we upgraded the library but missed the license change. Suggesting uplift so that we correct it as soon as reasonably possible.
[String/UUID change made/needed]: None
Attachment #8642462 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/1aac59a31bc3
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Mark, does any changes to licensing info have a l10n impact? Or are these always English only? Thanks.
Flags: needinfo?(standard8)
(In reply to Ritu Kothari (:ritu) from comment #6)
> Mark, does any changes to licensing info have a l10n impact? Or are these
> always English only? Thanks.

Its English-only, there's no localisation going on here.
Flags: needinfo?(standard8)
Comment on attachment 8642462 [details] [diff] [review]
Add React License for latest versions of React.

[Triage Comment]
Licensing related low-risk change, should be safe to uplift to Beta41
Attachment #8642462 - Flags: approval-mozilla-aurora? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.