Closed Bug 1190594 Opened 4 years ago Closed 4 years ago

Disable Allocations Flame Graph view

Categories

(DevTools :: Performance Tools (Profiler/Timeline), defect)

41 Branch
defect
Not set

Tracking

(firefox43 fixed)

RESOLVED FIXED
Firefox 43
Tracking Status
firefox43 --- fixed

People

(Reporter: jsantell, Assigned: jsantell)

References

Details

Attachments

(1 file)

This doesn't make sense -- should disable it until we have flame charts (count based, rather than time based domains) via bug 1123495.
Lets just remove it completely. We will always have the history.
No longer depends on: 1172180
This adds a pref to hide the flame graphs for memory so I don't have to go through all the tests to remove this

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c50ecbcfcb0d
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
Attachment #8644493 - Flags: review?(nfitzgerald)
Comment on attachment 8644493 [details] [diff] [review]
1190594-disable-memory-flame.patch

Review of attachment 8644493 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should actually remove the whole thing.
Attachment #8644493 - Flags: review?(nfitzgerald)
This pref isn't exposed in the UI anywhere, requiring test rewrites for its lack of existence. Maybe can handle this sometime in fx43 in that case
Assignee: jsantell → nobody
Status: ASSIGNED → NEW
Blocks: perf-tools-fx43
No longer blocks: perf-tools-fx42
Comment on attachment 8644493 [details] [diff] [review]
1190594-disable-memory-flame.patch

Review of attachment 8644493 [details] [diff] [review]:
-----------------------------------------------------------------

Let's just hide it for now, can get rid of it later, etc., practically speaking there's a colossal amount of front end work for Fx43 that won't be done in time, and rewriting tests to remove this from the code delivers little value only to us, for a terrible time on my end
Attachment #8644493 - Flags: review?(vporof)
Attachment #8644493 - Flags: review?(vporof) → review+
Assignee: nobody → jsantell
Status: NEW → ASSIGNED
https://hg.mozilla.org/mozilla-central/rev/23f1554d94b8
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.