1190594 - Disable Allocations Flame Graph view

Status: RESOLVED FIXED

(DevTools :: Performance Tools (Profiler/Timeline), defect)

Description

[Jordan Santell [:jsantell] [@jsantell]]

This doesn't make sense -- should disable it until we have flame charts (count based, rather than time based domains) via bug 1123495.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Lets just remove it completely. We will always have the history.

Comment 2

[Jordan Santell [:jsantell] [@jsantell]]

Attachment: 1190594-disable-memory-flame.patch

This adds a pref to hide the flame graphs for memory so I don't have to go through all the tests to remove this

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c50ecbcfcb0d

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8644493 [details] [diff] [review]
1190594-disable-memory-flame.patch

Review of attachment 8644493 [details] [diff] [review]:
-----------------------------------------------------------------

I think we should actually remove the whole thing.

Comment 4

[Jordan Santell [:jsantell] [@jsantell]]

This pref isn't exposed in the UI anywhere, requiring test rewrites for its lack of existence. Maybe can handle this sometime in fx43 in that case

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 8644493 [details] [diff] [review]
1190594-disable-memory-flame.patch

Review of attachment 8644493 [details] [diff] [review]:
-----------------------------------------------------------------

Let's just hide it for now, can get rid of it later, etc., practically speaking there's a colossal amount of front end work for Fx43 that won't be done in time, and rewriting tests to remove this from the code delivers little value only to us, for a terrible time on my end

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/23f1554d94b8

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/23f1554d94b8