Closed Bug 1190688 Opened 5 years ago Closed 5 years ago

Implement activeTab permission for open extension API

Categories

(WebExtensions :: Untriaged, defect, P1)

34 Branch
defect

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Iteration:
45.3 - Dec 14
Tracking Status
firefox45 --- fixed

People

(Reporter: billm, Assigned: kmag, Mentored)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, Whiteboard: [permissions])

Priority: -- → P1
Component: Extension Compatibility → WebExtensions
Product: Firefox → Toolkit
Duplicate of this bug: 1198402
Mentor: wmccloskey
Whiteboard: [permissions]
Blocks: webext
Flags: blocking-webextensions+
Assignee: nobody → kmaglione+bmo
Iteration: --- → 45.3 - Dec 14
https://hg.mozilla.org/integration/fx-team/rev/4a10c564dfca3189ab521c3ccfa92330163189b1
Bug 1190688: Part 1 - [webext] Implement the activeTab permission. r=billm

https://hg.mozilla.org/integration/fx-team/rev/1d5e9f3d094d075cfda767dd2108b07c7f8557de
Bug 1190688: Part 2 - [webext] Add tests for executeScript permission checks. r=billm
KWierso's having Bugzilla issues and asked me to add a comment to this bug on his behalf. This was backed out for frequent timeouts in the newly-added test.
https://hg.mozilla.org/integration/fx-team/rev/689eebc89b6d

https://treeherder.mozilla.org/logviewer.html#?job_id=6042877&repo=fx-team
Wow. We generate a surprising number of DOM windows for that test. Not sure how much I can cut it down, though. I guess I'll split it in two.
https://hg.mozilla.org/integration/fx-team/rev/72b3671ac8ef311a3469cb6ea74fe3bdd8ff21f1
Bug 1190688: Part 1 - [webext] Implement the activeTab permission. r=billm

https://hg.mozilla.org/integration/fx-team/rev/89e666316ea0c2cc12976b2bd7f6dc54c566e94f
Bug 1190688: Part 2 - [webext] Add tests for executeScript permission checks. r=billm
https://hg.mozilla.org/mozilla-central/rev/72b3671ac8ef
https://hg.mozilla.org/mozilla-central/rev/89e666316ea0
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
I've added a note on this: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/permissions#activeTab_permission.

Please let me know if this covers it.
Flags: needinfo?(kmaglione+bmo)
Looks good. Thanks
Flags: needinfo?(kmaglione+bmo)
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.