Open Bug 1191033 Opened 4 years ago Updated Last year

View source context menu and shortcuts only work if opened via UI (broken via view-source: URLs)

Categories

(Toolkit :: View Source, defect)

defect
Not set

Tracking

()

Tracking Status
firefox41 --- affected
firefox42 --- affected

People

(Reporter: aryx, Unassigned)

References

(Depends on 2 open bugs)

Details

Attachments

(1 file)

90.35 KB, application/zip
Details
Firefox Nightly 42.0a1 on Windows 8.1

The command shortcut to 'Go to Line' in View Source only works if the source got opened in a new tab.

Steps to reproduce:
1. Open a page, e.g. https://wiki.mozilla.org/Main_Page
2. Use either context or Web developer menu to open the source which will open in a new tab.
3. Press Alt+Shift+L (Win/Linux) or Cmd+Opt+L (Mac) to call the 'Go To Line' command.
Actual & expected results: Works.
4. Copy the url of the tab. view-source:https://wiki.mozilla.org/Main_Page
5. Close the tab.
6. Paste the url in the location bar of the tab which contains the wiki page.
7. Press Alt+Shift+L (Win/Linux) or Cmd+Opt+L (Mac) to call the 'Go To Line' command.
Actual result:
Shortcut doesn't work (even after clicking into the source view before pressing the shortcut again). Same issue if the url gets manually prefixed with view-source:
I was able to repro this on 41.0a2 BuildID: 20150802004005 on windows8.
Is this broken irrespective of e10s?
This issue happens with e10s enabled and disabled.
It could be platform specific, I can't seem to reproduce on Mac.
(In reply to J. Ryan Stinnett [:jryans] (use ni?) from comment #4)
> It could be platform specific, I can't seem to reproduce on Mac.

Never mind, I can reproduce on Mac now.  I might not have followed the STR correctly the first time.
Attached file c0.zip
Confirmed on:

Windows 7/8.1
Ubuntu 15.04

Firefox 43.0a1 (build ID 20150817061040)

And it doesn't work because... see attached the file "c0.zip" (this item isn't in the menu).
We currently only create the "enhanced" view source mode (with additional go to line functions, etc.) when:

* The view source tab is created through UI actions meant for viewing source
* A view source tab is restored by session restore

We'll need some mechanism that loads a frame script when a certain URL pattern is matched, as discussed in bug 1171720 comment 5 to make this work and avoid Talos regressions for regular browsing.
Depends on: 1171720, 1171986
Summary: Command shortcut to 'Go to Line' only works if source opened in new tab → View source context menu and shortcuts only work if opened via UI (broken via view-source: URLs)
You need to log in before you can comment on or make changes to this bug.