1308049 - "Go to Line..." does not work on view source after detach the view source tab

Status: RESOLVED WORKSFORME

(Toolkit :: View Source, defect, P2)

Description

[Alice0775 White]

To comparison between original page and page source, I detached the View Page Source tab.
In this case, "Go to Line..." does not work.

Steps to reproduce:
1. Open any web page
2. Open View Page Source (Ctrl+U)
3. Detach the View Page Source tab
4. Right click on the View Page Source tab and select "Go to Line..."

Actual results;
 No thing

Expected Results:
 "Enter line number" dialog should open

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Hi Ryan, this appears to be a regression from your patch in bug 1067325. Can you please take a look?

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Yes, it's true these features break down at the moment if you detach the tab.

Since we've been shipping this mode for some time now, I don't think we should track this in the same way as a recent regression.  It should be prioritized as we would any regular error or missing feature.

Comment 3

[Julien Cristau [:jcristau]]

Mass wontfix for bugs affecting firefox 52.

Comment 4

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Moved to the backlog (P3) since nobody is working on it now.
Honza

Comment 5

[Boris Zbarsky [:bzbarsky]]

Is there any plan to actually fix this? This is making view-source pretty much completely unusable for me: I want to go to the line an error is on, but of course that does not work... I end up having to copy/paste things into an editor instead.

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Redirecting to Patrick... I am not very active in this component at the moment. Maybe it should have a new triage owner?

Comment 7

[Patrick Brosset <:pbro>]

Honza does the triage for view source these days. So forwarding to him.
Honza, would you mind filing the bug to change the triage owner to you?

Comment 8

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to Patrick Brosset <:pbro> from comment #7)

Honza, would you mind filing the bug to change the triage owner to you?

Done

I'll keep NI to myself, to investigate this later.

Honza

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I was debugging this quickly and the issue seems to be communication between the frame script and ViewSourceBrowser.

1. Go to line menu action is implemented here:
   https://searchfox.org/mozilla-central/rev/3366c3d24f1c3818df37ec0818833bf085e41a53/toolkit/components/viewsource/content/viewSource-content.js#747

It's based on sending a message
sendAsyncMessage("ViewSource:PromptAndGoToLine");

2. The message should be handled by ViewSourceBrowser here:
   https://searchfox.org/mozilla-central/rev/3366c3d24f1c3818df37ec0818833bf085e41a53/toolkit/components/viewsource/ViewSourceBrowser.jsm#113

But the handler is never executed.

I am setting P2, since this should be fixed and there are likely other messages not being handled properly.

Honza

Comment 10

[Gregory Pappas [:gregp]]

I can't reproduce this anymore. I got this pushlog with mozregression --arg=https://bugzilla.mozilla.org/show_bug.cgi?id=1308049 --good 2021-06-16 --bad 2019-08-15 --find-fix. I assume bug 1505915 fixed this. Honza, what do you think?

Comment 11

[Jan Honza Odvarko [:Honza] (always need-info? me)]

I can confirm, this works for me in Fx 103 (Nightly) as well as in Fx 101 (Release). Tested on Win10
Thank you for the ping, Gregory.
Closing