Closed Bug 1191941 Opened 7 years ago Closed 7 years ago

Disable addon signing via comm-central mozconfigs


(Thunderbird :: Build Config, defect)

39 Branch
Not set



Thunderbird 43.0
Tracking Status
thunderbird41 + ---


(Reporter: Fallen, Assigned: Fallen)



(1 file, 1 obsolete file)

bug 1186522 will add add-on signing to mozconfig.common, but we want to disable it. We need to do this in some file that includes build/mozconfig.common, right now this is each platform mozconfig.

I think we could solve this by creating mail/configs/mozconfigs/mozconfig.common, which includes /build/mozconfig.common and then can be included from our platform specific mozconfigs. This would also allow us to add things like --enable-calendar there.

Maybe there are other options though. jcranmer?
Flags: needinfo?(Pidgeot18)
We basically can't touch anything in build/*, since that's effectively identical to mozilla-central (mozconfigs are REALLY wonky) there. Making a common mail mozconfig base might be a good idea.
Flags: needinfo?(Pidgeot18)
I've been wondering about this.

Say we get the nightly from mail/config/mozconfigs/*platform*.

It's my understanding that |. mail/configs/mozconfigs/mozconfig.common| won't
work with our current build config (and probably by extension, relative
paths won't work as well).

so would it make sense to have some sort of fixed topsrcdir set? (kinda
cheating I know:  i.e.   if "mozilla" in topsrcdir,  use relative paths 
(../mail/...)  otherwise, use the actual path  i.e. mail/...
Attached patch Fix - v1 (obsolete) β€” β€” Splinter Review
ewong, yes, there needs to be some changes to the mozconfigs to make it work like you suggested. I've done this in bug 1195468. This patch requires all dependent bugs to be applied/pushed.

I hope disabling everything is the right way to go about it. Maybe that will have the nice side-effect of fixing tests that fail because of addon-signing being enabled.
Assignee: nobody → philipp
Attachment #8648902 - Flags: review?(Pidgeot18)
This is needed prior to a beta release IIUC
Attached patch Fix - v2 β€” β€” Splinter Review
As we aren't doing the whole common mozconfig dance now, here is a patch that adds it to all mozconfigs. I've added it after including mozconfig.common because that is what jlund is doing in attachment 8656163 [details] [diff] [review].
Attachment #8648902 - Attachment is obsolete: true
Attachment #8648902 - Flags: review?(Pidgeot18)
Attachment #8658270 - Flags: review?(Pidgeot18)
No longer depends on: 1195143, 1195462, 1195468
Attachment #8658270 - Flags: review?(Pidgeot18) → review+
Pushed to comm-central changeset cfb6f301cc13
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 43.0
You need to log in before you can comment on or make changes to this bug.