Improve inclusion system for mozconfigs in c-c vs m-c

RESOLVED WONTFIX

Status

RESOLVED WONTFIX
3 years ago
2 years ago

People

(Reporter: Fallen, Assigned: Fallen)

Tracking

39 Branch

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

It would be nice if we could include mozconfigs from mail and also no longer need to check-sync-dirs in the build/ directory.
Created attachment 8648894 [details] [diff] [review]
Fix - v1

As it's hard to test these changes I have no idea if it works, but from what I have been testing it seems to do fine, at least on macosx64.
Assignee: nobody → philipp
Status: NEW → ASSIGNED
Attachment #8648894 - Flags: review?(Pidgeot18)
Created attachment 8648897 [details] [diff] [review]
Comparison of options before and after patch

I built myself a simple dumper that dumps all ac/mk_add_options as well as all set environment variables and ran it before and after applying this patch. Here is the output of the differences. Things to note:

* removed ac_add_options --enable-profiling from macosx64/l10n-mozconfig
* MOZILLA_OFFICIAL and MOZ_DEBUG_SYMBOLS are now set on all builds
  - most notably on l10n-mozconfig builds (where it shouldn't affect anything)
  - and debug builds.
* --enable-profiling now removed from macosx64/l10n-mozconfig
* for some reason, win64/debug, win64/nightly and win64/l10n-mozconfig was missing MOZ_DEBUG_SYMBOLS
* for some reason, win64/l10n-mozconfig was missing --with-l10n-base and using the wrong client.py-args
* mozconfig.cache is now used on all platforms, which enables ccache
I am not quite sure if I have done enough to remove the sync'd files from c-c/build/, or if there are any caveats in doing so. I am also not quite sure if the TOOLTOOL_DIR needs to be c-c, but it should be simple to do so if needed. Also, if there is an easier way to execute a common mozconfig at the beginning of each toplevel mozconfig, that would be great.

Also, while we are at it, what do we need to do to remove the tooltool manifests from c-c? I suspect we can go for a similar solution, maybe setting TOOLTOOL_DIR the way it is now is even enough?
Flags: needinfo?(Pidgeot18)
(In reply to Philipp Kewisch [:Fallen] from comment #3)
> I am not quite sure if I have done enough to remove the sync'd files from
> c-c/build/, or if there are any caveats in doing so. I am also not quite
> sure if the TOOLTOOL_DIR needs to be c-c, but it should be simple to do so
> if needed. Also, if there is an easier way to execute a common mozconfig at
> the beginning of each toplevel mozconfig, that would be great.
> 
> Also, while we are at it, what do we need to do to remove the tooltool
> manifests from c-c? I suspect we can go for a similar solution, maybe
> setting TOOLTOOL_DIR the way it is now is even enough?

I suspect tooltool needs to remain in c-c, since I think we run tooltool before we can guarantee the existence of mozilla-central. So the answer to your question is really "we have to solve the bloody m-c/c-c split problem." :-(
Flags: needinfo?(Pidgeot18)
Comment on attachment 8648894 [details] [diff] [review]
Fix - v1

As discussed on IRC, retracting this review until further notice. This may have so many unforeseen consequences that we'd rather wait until the general direction for the build system is clear.
Attachment #8648894 - Flags: review?(Pidgeot18)
(Assignee)

Updated

3 years ago
No longer blocks: 1191941
Unlikely this will happen, will reopen if it does
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.