1192192 - [Camera]Set a self-timer and take a photo, the count down number of self-timer can't be displayed.

Status: VERIFIED FIXED

(Core :: Graphics, defect)

Description

[Shine(Leave from Mozilla)]

Attachment: Aries_KK_2.5.3gp

[1.Description]:
[Aries KK v2.5][Flame KK v2.5][Camera]Launch Camera,  set a self-timer and take a photo, the count down number of self-timer can't be displayed.
See attachment: logcat_Aries_KK_2.5.txt & Aries_KK_2.5.3gp
Found time: 17:13

[2.Testing Steps]: 
1. Launch Camera.
2. Tap Settings button.
3. Tap "Self-Timer" and select a time.
4. Go back to capture view and take a photo.

[3.Expected Result]: 
4. The count down number of self-timer could be displayed normally.

[4.Actual Result]: 
4. The count down number of self-timer can't be displayed.

[5.Reproduction build]: 
Device: Aries KK 2.5(Affected)
Build ID               20150806003241
Gaia Revision          581de383687dc441a878d2c91a0167c6ec688fef
Gaia Date              2015-08-05 01:48:40
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9801f91760d9
Gecko Version          42.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150805.235801
Firmware Date          Wed Aug  5 23:58:08 UTC 2015
Bootloader             s1

Device: Flame KK 2.2(Unaffected)
Build ID               20150806032503

Gaia Revision          f8b119ac30e97df991c97682ac4d4f9ca22e1793

Gaia Date              2015-07-31 13:20:55

Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g37_v2_2/rev/a9379f716e9f

Gecko Version          37.0

Device Name            flame

Firmware(Release)      4.4.2

Firmware(Incremental)  eng.cltbld.20150806.065240

Firmware Date          Thu Aug  6 06:52:51 EDT 2015

Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Flame KK v2.5(Affected):
Build ID               20150806103226
Gaia Revision          497fe3f938722b0aa49c93f975fad5d9ed3b0a82
Gaia Date              2015-08-06 05:30:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/2fad09a0540d
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150806.135403
Firmware Date          Thu Aug  6 13:54:17 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,10/10

[7.TCID]: 
13279

Comment 1

[Shine(Leave from Mozilla)]

Attachment: logcat_Aries_KK_2.5.txt

Comment 2

[Norry.L.F(Leave from Mozilla)]

[Blocking Requested - why for this release]: impact user obviously, nominate.

Comment 3

[Annabelle]

mozilla-inbound Regression Window:
Last Working Environmental Variables:
Device: Flame KK v2.5
Build ID               20150804113949
Gaia Revision          67c38af8347f93ddc005a53f427d651b744b55c1
Gaia Date              2015-08-04 05:37:19
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/29cc14174cc7
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150805.063609
Firmware Date          Wed Aug  5 06:36:20 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Environmental Variables:
Device: Flame KK v2.5
Build ID               20150804120843
Gaia Revision          67c38af8347f93ddc005a53f427d651b744b55c1
Gaia Date              2015-08-04 05:37:19
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/48f9d0c0f352
Gecko Version          42.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150805.063609
Firmware Date          Wed Aug  5 06:36:20 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

First Broken Gaia & Last Working Gecko - issue DOES NOT repro
Gaia Revision          67c38af8347f93ddc005a53f427d651b744b55c1
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/29cc14174cc7

First Broken Gecko & Last Working Gaia – issue DOES repro
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/48f9d0c0f352
Gaia Revision          67c38af8347f93ddc005a53f427d651b744b55c1

Gecko pushlog: 
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=29cc14174cc7&tochange=48f9d0c0f352

Comment 4

[Blake Wu [:bwu][:blakewu]]

Hi Munro, 
From comment 3, it looks like a gecko bug.
Can you have a look?

Comment 5

[Munro Mengjue Chiang [:mchiang] Be Mozillian since 1/19/2018]

Jerry,

This is related to http://hg.mozilla.org/integration/mozilla-inbound/rev/28fac8d7cdde
Please help check the composition issue.

Comment 6

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Let me check if the culling method is still not correct. : (

Comment 7

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Attachment: Fix quad culling method.

We also need to consider the program->SetRenderOffset() offset for culling.
I will have a testing code for these drawQuad culling error.

Comment 8

[Jerry Shih[:jerry] (UTC+8) (inactive)]

try link: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f760bb10c4f

Comment 9

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Please land the attachment 8646231 [details] [diff] [review] to m-c
try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1f760bb10c4f

Comment 10

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/513d1660a8d4

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/513d1660a8d4

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/513d1660a8d4

Comment 14

[Annabelle]

Attachment: Verified_Aries(kk)_v2.5.3GP

This bug has been verified as "pass" on latest build of Flame kk v2.5 and Aries kk v2.5 by the STR in Comment 0.
Actual results: The count down number of self-timer could be displayed normally.

See attachment: Verified_Aries(kk)_v2.5.3gp
Reproduce rate: 0/5

Device: Aries KK 2.5(Pass):
Build ID               20150814002719
Gaia Revision          39b121515ab8a8c3ea07f26d3ba1dd792e90217c
Gaia Date              2015-08-13 18:25:42
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/4e883591bb5dff021c108d3e30198a99547eed1e
Gecko Version          43.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20150813.235024
Firmware Date          Thu Aug 13 23:50:32 UTC 2015
Bootloader             s1

Device: Flame KK v2.5(Pass):
Build ID               20150816150205
Gaia Revision          47c91ffe7f500ca1aaa60de0aabf4d2429120733
Gaia Date              2015-08-14 18:55:02
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9
Gecko Version          43.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20150816.182145
Firmware Date          Sun Aug 16 18:21:56 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 15

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Comment on attachment 8646231 [details] [diff] [review]
Fix quad culling method.

Approval Request Comment
[Feature/regressing bug #]:
Bug 1199600.

[User impact if declined]:
We can't see the scroll bar in Customize Mode.

[Describe test coverage new/current, TreeHerder]:
It's already at m-c. I try to uplift this patch to aurora locally, and the scroll bar goes back.

[Risks and why]: 
low.

[String/UUID change made/needed]:
none

Comment 16

[Sylvestre Ledru [:Sylvestre]]

Jerry, why should we take this patch in Firefox 42? Thanks

Comment 17

[Jerry Shih[:jerry] (UTC+8) (inactive)]

Hi Sylvestre,
We have a bug 1199600 that we can't see the scroll bar in ui customize mode. This patch could fix that. It's in m-c, but doesn't in Firefox42.

Comment 18

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8646231 [details] [diff] [review]
Fix quad culling method.

OK, thanks, let's try with it then.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/355d8a2719ac