1192276 - Restore about:privatebrowsing UI to before it was messed up by Project Chameleon styles

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[Philip Chee]

+++ This bug was initially created as a clone of Bug #1133380 +++
> Bug 1125636 changed the theming of about:config which we were borrowing from.

Comment 1

[Philip Chee]

Attachment: Patch v1.0 Proposed fix.

Restore the UI to before Project Chameleon
1. Revert XUL
1.1. Stop using in-content/info-pages.css and global/config.css
2. Copy styles that we need from the old config.css to aboutPrivateBrowsing.css
3. Copy PNGs from toolkit that we were using - some of which don't exist any more. I managed to find them in mozilla-release.

The result is that we don't depend on anything in toolkit theme for about:privatebrowsing

Comment 2

[Stefan [:stefanh]]

Comment on attachment 8645000 [details] [diff] [review]
Patch v1.0 Proposed fix.

I won't be able to look at this until after August 25. Karsten might be an option if you're in a hurry.

Comment 3

[[e-mail]]

Comment on attachment 8645000 [details] [diff] [review]
Patch v1.0 Proposed fix.

Which version of aboutPrivateBrowsing.xul will third-party themes prefer?

Should Modern @import its config.css to avoid the duplication?

Speaking of which, are there plans to revert the look of about:config?

Comment 4

[Alfred Kayser]

I am ok with this change. This will make seamonkey less dependent on all the changes that are being done for Firefox (which I also don't like that much...)

Comment 5

[Philip Chee]

(In reply to [e-mail] from comment #3)
> Comment on attachment 8645000 [details] [diff] [review]
> Patch v1.0 Proposed fix.
> 
> Which version of aboutPrivateBrowsing.xul will third-party themes prefer?
I suspect the reverted version in my patch. I could ask the in the Theme Dev forum in Mozillazine.

> Should Modern @import its config.css to avoid the duplication?
I think misusing config.css to style the private browsing was sub-optimal. In Modern we could use in-content/info-pages.css if you want to avoid duplication. Plus in classic we override the toolkit info-pages.css

> Speaking of which, are there plans to revert the look of about:config?
It's on my TODO list but not exactly at the top of of the list. If someone else wants to do this, welcome.

Comment 6

[Philip Chee]

I've asked for comments from third party themers in Mozillazine:
http://forums.mozillazine.org/viewtopic.php?f=18&t=2954291

Comment 7

[[e-mail]]

Comment on attachment 8645000 [details] [diff] [review]
Patch v1.0 Proposed fix.

I tested this on Windows, Mac and Linux, and it seems to be fine. You even restored an underline which had gone missing in the Modern theme!

Comment 8

[Robert Kaiser]

FWIW, I prefer us keeping everything as close to Firefox as possible, as I'm following that with my theming work (also has the upside of actually releasing builds to the public), but as long as Firefox and SeaMonkey don't expect different content at the same chrome address, I can deal with differences.

Comment 9

[Philip Chee]

Patrick Dempsey agrees with Alfred Kayser.

Comment 10

[Stefan [:stefanh]]

Comment on attachment 8645000 [details] [diff] [review]
Patch v1.0 Proposed fix.

Yeah, this looks now like current release.

Comment 11

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/87e3cb843f65

Comment 12

[Philip Chee]

Comment on attachment 8645000 [details] [diff] [review]
Patch v1.0 Proposed fix.

[Approval Request Comment]
Regression caused by (bug #): Bug 1097111 - Update all about: pages to Project Chameleon
User impact if declined: awful looking about:privatebrowsing in classic theme.
Testing completed (on m-c, etc.): baked on comm-central for a while.
Risk to taking this patch (and alternatives if risky): Low risk mostly CSS changes.
String changes made by this patch: None

Comment 13

[Ian Neal]

Comment on attachment 8645000 [details] [diff] [review]
Patch v1.0 Proposed fix.

a=me

Comment 14

[Philip Chee]

http://hg.mozilla.org/releases/comm-aurora/rev/0e6fd3bedbfb
http://hg.mozilla.org/releases/comm-beta/rev/92570e1ca52e
http://hg.mozilla.org/releases/comm-release/rev/83f2af2ad036

Comment 15

[rsx11m]

(In reply to [e-mail] from comment #3)
> Should Modern @import its config.css to avoid the duplication?
> Speaking of which, are there plans to revert the look of about:config?

Is there a bug for reverting about:config appearance in Classic already?

Also, about:support and about:addons are other shared Toolkit pages recently redesigned.

If there is consensus that the Chameleon style isn't wanted for SeaMonkey it should be consistently reverted (and adaptions are needed for Modern anyway whenever Toolkit makes any layout changes).

[I'm commenting here rather than in meta bug 1133743 given that more people are watching this bug.]

Comment 16

[Philip Chee]

There are two patches that need to land first:
1. comm-central Bug 1022354 Move override for defaultFavicon from content to classic skin now that Bug 1170207 is fixed
2. mozilla central Bug 1189918 - Theme overrides should work in safe mode for comm-central applications too.

Once these two bugs land we can safely use override directives in theme manifests without screwing up third party themes.