Remove PlayPreview registration from Shumway

RESOLVED FIXED in Firefox 43

Status

Firefox Graveyard
Shumway
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: yury, Assigned: yury)

Tracking

Trunk
Firefox 43
Dependency tree / graph

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

2 years ago
Sister bug of PlayPreview removal in PDF viewer (bug 1179262).

Preparing m-c for removal of PlayPreview API. We are loosing whitelisting and fallback to Flash Player capabilities. For that reason we set shumway.disabled to true by default.
(Assignee)

Comment 1

2 years ago
Created attachment 8645246 [details] [diff] [review]
Remove PlayPreview registration from Shumway.
Attachment #8645246 - Flags: feedback?(till)
Comment on attachment 8645246 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

Review of attachment 8645246 [details] [diff] [review]:
-----------------------------------------------------------------

We discussed this on IRC, too. Looks "good", in that it fixes the issues we want fixed, and will have to live with not having a whitelist for now.
Attachment #8645246 - Flags: feedback?(till) → feedback+
(Assignee)

Updated

2 years ago
Blocks: 1192831
(Assignee)

Comment 3

2 years ago
Comment on attachment 8645246 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

(since bz is on vacation) Peter, can you glance at this patch to facilitate quicker PlayPreview removal? It's almost the similar changes as in bug 1192831.
Attachment #8645246 - Flags: review?(peterv)
(Assignee)

Updated

2 years ago
Assignee: nobody → ydelendik
(Assignee)

Comment 4

2 years ago
(In reply to Yury Delendik (:yury) from comment #3)
> Comment on attachment 8645246 [details] [diff] [review]
> It's almost the similar changes as in bug 1192831.

Sorry, bug bug 1179262.
(Assignee)

Comment 5

2 years ago
Created attachment 8649018 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

Rebased and extension typo is corrected.

(https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd120f341fa6)
Attachment #8645246 - Attachment is obsolete: true
Attachment #8645246 - Flags: review?(peterv)
Attachment #8649018 - Flags: review?(bugs)

Comment 6

2 years ago
Comment on attachment 8649018 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

Review of attachment 8649018 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments addressed.

::: browser/app/profile/firefox.js
@@ +1688,5 @@
>  pref("pdfjs.previousHandler.alwaysAskBeforeHandling", false);
>  
>  // Shumway is only bundled in Nightly.
>  #ifdef NIGHTLY_BUILD
>  // By default, Shumway (SWF player) is only enabled for whitelisted SWFs on Windows + OS X.

Remove this comment

::: docshell/base/nsWebNavigationInfo.cpp
@@ +51,5 @@
>      return NS_OK;
>    }
>  
> +  // We want to claim that the type for SWF movies is unsupported,
> +  // so that the internal SWF player's stream converted will get used.

s/converted/converter

::: dom/base/nsContentUtils.cpp
@@ +6578,5 @@
>  
> +bool
> +nsContentUtils::IsSWFPlayerEnabled()
> +{
> +   nsCOMPtr<nsIStreamConverterService> convServ =

Do we need to check the Shumway pref here?
Attachment #8649018 - Flags: review?(bugs) → review+
(Assignee)

Comment 7

2 years ago
Created attachment 8649348 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

(In reply to Jet Villegas (:jet) from comment #6)
> Comment on attachment 8649018 [details] [diff] [review]
> Remove PlayPreview registration from Shumway.
> 
> Review of attachment 8649018 [details] [diff] [review]:
> -----------------------------------------------------------------
> >  // By default, Shumway (SWF player) is only enabled for whitelisted SWFs on Windows + OS X.
> 
> Remove this comment

Fixed.

> ::: docshell/base/nsWebNavigationInfo.cpp
> s/converted/converter

Fixed.

> 
> ::: dom/base/nsContentUtils.cpp
> > +nsContentUtils::IsSWFPlayerEnabled()
> > +{
> > +   nsCOMPtr<nsIStreamConverterService> convServ =
> 
> Do we need to check the Shumway pref here?

The contract for application/x-shockwave-flash -> text/html is a "sign" that we already handled the Shumway-is-on preference(s). See also comment at https://bugzilla.mozilla.org/show_bug.cgi?id=1179262#c6 about the decision made at bug 1179262.
Attachment #8649018 - Attachment is obsolete: true
(Assignee)

Updated

2 years ago
Keywords: checkin-needed
(Assignee)

Updated

2 years ago
See Also: → bug 1194343

Comment 8

2 years ago
https://hg.mozilla.org/integration/fx-team/rev/89776b90cb3b
Keywords: checkin-needed
https://hg.mozilla.org/integration/fx-team/rev/89776b90cb3b
https://hg.mozilla.org/mozilla-central/rev/89776b90cb3b
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox43: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43

Updated

2 years ago
Blocks: 1197596
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.