1192450 - Remove PlayPreview registration from Shumway

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Yury Delendik (:yury)]

Sister bug of PlayPreview removal in PDF viewer (bug 1179262).

Preparing m-c for removal of PlayPreview API. We are loosing whitelisting and fallback to Flash Player capabilities. For that reason we set shumway.disabled to true by default.

Comment 1

[Yury Delendik (:yury)]

Attachment: Remove PlayPreview registration from Shumway.

Comment 2

[Till Schneidereit [:till]]

Comment on attachment 8645246 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

Review of attachment 8645246 [details] [diff] [review]:
-----------------------------------------------------------------

We discussed this on IRC, too. Looks "good", in that it fixes the issues we want fixed, and will have to live with not having a whitelist for now.

Comment 3

[Yury Delendik (:yury)]

Comment on attachment 8645246 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

(since bz is on vacation) Peter, can you glance at this patch to facilitate quicker PlayPreview removal? It's almost the similar changes as in bug 1192831.

Comment 4

[Yury Delendik (:yury)]

(In reply to Yury Delendik (:yury) from comment #3)
> Comment on attachment 8645246 [details] [diff] [review]
> It's almost the similar changes as in bug 1192831.

Sorry, bug bug 1179262.

Comment 5

[Yury Delendik (:yury)]

Attachment: Remove PlayPreview registration from Shumway.

Rebased and extension typo is corrected.

(https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd120f341fa6)

Comment 6

[Jet Villegas (inactive)]

Comment on attachment 8649018 [details] [diff] [review]
Remove PlayPreview registration from Shumway.

Review of attachment 8649018 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with comments addressed.

::: browser/app/profile/firefox.js
@@ +1688,5 @@
>  pref("pdfjs.previousHandler.alwaysAskBeforeHandling", false);
>  
>  // Shumway is only bundled in Nightly.
>  #ifdef NIGHTLY_BUILD
>  // By default, Shumway (SWF player) is only enabled for whitelisted SWFs on Windows + OS X.

Remove this comment

::: docshell/base/nsWebNavigationInfo.cpp
@@ +51,5 @@
>      return NS_OK;
>    }
>  
> +  // We want to claim that the type for SWF movies is unsupported,
> +  // so that the internal SWF player's stream converted will get used.

s/converted/converter

::: dom/base/nsContentUtils.cpp
@@ +6578,5 @@
>  
> +bool
> +nsContentUtils::IsSWFPlayerEnabled()
> +{
> +   nsCOMPtr<nsIStreamConverterService> convServ =

Do we need to check the Shumway pref here?

Comment 7

[Yury Delendik (:yury)]

Attachment: Remove PlayPreview registration from Shumway.

(In reply to Jet Villegas (:jet) from comment #6)
> Comment on attachment 8649018 [details] [diff] [review]
> Remove PlayPreview registration from Shumway.
> 
> Review of attachment 8649018 [details] [diff] [review]:
> -----------------------------------------------------------------
> >  // By default, Shumway (SWF player) is only enabled for whitelisted SWFs on Windows + OS X.
> 
> Remove this comment

Fixed.

> ::: docshell/base/nsWebNavigationInfo.cpp
> s/converted/converter

Fixed.

> 
> ::: dom/base/nsContentUtils.cpp
> > +nsContentUtils::IsSWFPlayerEnabled()
> > +{
> > +   nsCOMPtr<nsIStreamConverterService> convServ =
> 
> Do we need to check the Shumway pref here?

The contract for application/x-shockwave-flash -> text/html is a "sign" that we already handled the Shumway-is-on preference(s). See also comment at https://bugzilla.mozilla.org/show_bug.cgi?id=1179262#c6 about the decision made at bug 1179262.

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/89776b90cb3b

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/89776b90cb3b

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/89776b90cb3b