1192625 - [UX] New visual design for the updated about:privatebrowsing page

Status: RESOLVED FIXED

(Firefox :: Private Browsing, defect, P1)

Description

[:Paolo Amadini]

The strings of about:privatebrowsing were reviewed just before string freeze in a way that requires a visual design change, but unfortunately we didn't get the visual design specification at the same time.

This means we had to land the current design, while hiding the strings that still don't fit in the visual design. As soon as we get the new design, we have to use the hidden strings and delete the ones that are now present to fit into the old design.

These are the strings that will be replaced:

aboutPrivateBrowsing.subtitle
aboutPrivateBrowsing.info.forgotten
aboutPrivateBrowsing.info.kept

Comment 1

[Francesco Lodolo [:flod]]

As noted in bug 1192088 comment 11, I don't consider helpful removing strings on mozilla-aurora when the new design lands. 

I think it will make sense to remove them on mozilla-central, and let the removal ride the trains, unless it creates too many technical issues (you'll need a patch specific for mozilla-aurora).

Comment 2

[bbell]

Attachment: example.png

This is an example of how the current layout differs from the mock-up.

Comment 3

[bbell]

Attachment: notes.png

Here are some notes on the changes needed.

Comment 4

[:Paolo Amadini]

Hi Bryan, we should probably meet and talk a bit more about how the page is implemented - in particular our requirements for localization. We've also redefined some of the strings and we should make space for them in the design, if it still makes sense.

Comment 5

[Théo Chevalier]

In bug 1192088, the string "Private Windows now block content that tracks your browsing activity." as been explicitly changed into "Private Windows now block parts of the page that may track your browsing activity.", has this decision just been reverted?
I can still see "may" in https://docs.google.com/document/d/134Ez8FpoMVkJ72a4ux8t6mPVNTU8iNPwAa5On4cUQwU/edit?pli=1 and other strings (Android for instance) are also using "may". Is this change intended? Removing "may" will break the string freeze.


New string: "Please Note: that your employer or Internet service provider can still track the pages you visit."
String landed on Aurora: "Please note that your employer or Internet service provider can still track the pages you visit."

This is going to break the string freeze.


New string: "Learn More…"
String landed on Aurora: "Learn More."

This is also going to break the string freeze.

Comment 6

[:Paolo Amadini]

(In reply to Francesco Lodolo [:flod] from comment #1)
> As noted in bug 1192088 comment 11, I don't consider helpful removing
> strings on mozilla-aurora when the new design lands. 

Yeah, sorry, I didn't understand what you were asking for originally. We definitely don't need to remove the strings on m-a, we can just leave them there unused and remove in m-c.

Comment 7

[:Paolo Amadini]

(In reply to Théo Chevalier [:tchevalier] from comment #5)
> In bug 1192088, the string "Private Windows now block content that tracks
> your browsing activity." as been explicitly changed into "Private Windows
> now block parts of the page that may track your browsing activity."

That's because the latest copy review document on which that change is based is now:

https://docs.google.com/document/d/134Ez8FpoMVkJ72a4ux8t6mPVNTU8iNPwAa5On4cUQwU/edit?pli=1

Yeah, tracking these things in various Google Docs isn't always the best way to keep everyone updated... fortunately we can just talk to each other :-)

> New string: "Learn More…"
> String landed on Aurora: "Learn More."

While this is unspecified in the document, we're reusing the old string here and I don't think we'd want to break string freeze for a single difference like this in any case.

Comment 8

[Théo Chevalier]

(In reply to :Paolo Amadini from comment #7)
> (In reply to Théo Chevalier [:tchevalier] from comment #5)
> > In bug 1192088, the string "Private Windows now block content that tracks
> > your browsing activity." as been explicitly changed into "Private Windows
> > now block parts of the page that may track your browsing activity."
> 
> That's because the latest copy review document on which that change is based
> is now:
> 
> https://docs.google.com/document/d/
> 134Ez8FpoMVkJ72a4ux8t6mPVNTU8iNPwAa5On4cUQwU/edit?pli=1
> 
> Yeah, tracking these things in various Google Docs isn't always the best way
> to keep everyone updated... fortunately we can just talk to each other :-)

Ah, thanks. However, I still see in this doc the strings that have landed on Aurora: "Private Windows now block parts of the page that may track your browsing activity." and "Please note that your employer or Internet service provider can still track the pages you visit.".
So it's fine to keep them?


> 
> > New string: "Learn More…"
> > String landed on Aurora: "Learn More."
> 
> While this is unspecified in the document, we're reusing the old string here
> and I don't think we'd want to break string freeze for a single difference
> like this in any case.

Glad to hear that. Not sure which string you are talking about, though. In Aurora we only have "Learn More." in aboutPrivateBrowsing.dtd. But if we can reuse another one, that should be fine.

Comment 9

[:Paolo Amadini]

(In reply to Théo Chevalier [:tchevalier] from comment #8)
> "Private Windows now block parts of the page that may track your
> browsing activity." and "Please note that your employer or Internet service
> provider can still track the pages you visit.".
> So it's fine to keep them?

Yeah, these strings will be kept.

> Glad to hear that. Not sure which string you are talking about, though. In
> Aurora we only have "Learn More." in aboutPrivateBrowsing.dtd. But if we can
> reuse another one, that should be fine.

I'm saying the "Learn more." link should keep the same translation it always had in the old design of the page, the entity name is unchanged.

Comment 10

[Théo Chevalier]

(In reply to :Paolo Amadini from comment #9)
> (In reply to Théo Chevalier [:tchevalier] from comment #8)
> > "Private Windows now block parts of the page that may track your
> > browsing activity." and "Please note that your employer or Internet service
> > provider can still track the pages you visit.".
> > So it's fine to keep them?
> 
> Yeah, these strings will be kept.

Perfect, thanks for the clarification. I've been a bit scared by the attachments in this bug :)

> 
> > Glad to hear that. Not sure which string you are talking about, though. In
> > Aurora we only have "Learn More." in aboutPrivateBrowsing.dtd. But if we can
> > reuse another one, that should be fine.
> 
> I'm saying the "Learn more." link should keep the same translation it always
> had in the old design of the page, the entity name is unchanged.

Oh, alright. Didn't notice the entity was the same as before.

Thank you

Comment 11

[:Paolo Amadini]

(In reply to Théo Chevalier [:tchevalier] from comment #10)
> Perfect, thanks for the clarification. I've been a bit scared by the
> attachments in this bug :)

I'll hide those for now until I talk with Bryan, maybe tomorrow if we can make time.

Comment 12

[bbell]

Attachment: 2_column_mockup.png

here's the mock-up with the new string changes.

Comment 13

[Francesco Lodolo [:flod]]

(In reply to bbell from comment #12)
> Created attachment 8647659 [details]
> 2_column_mockup.png
> 
> here's the mock-up with the new string changes.

I count at least 5 strings in this mock-up that are not available in mozilla-aurora. In this just a reference for the layout? If it's not, we have a problem.

Comment 14

[Javaun Moradi [:javaun]]

Flod: I can tell by reading that the text in the mockup is not the final copy we settled on with Matej and that Paolo landed. I would assume this is reference copy and we're still good unless I see otherwise.

Comment 15

[Javaun Moradi [:javaun]]

Sorry, to be clear: all copy changes go through legal/Matej, and the final strings are what Paolo landed last week. If there were  changes, we would know about them

Comment 16

[Francesco Lodolo [:flod]]

(In reply to Javaun Moradi [:javaun] from comment #15)
> Sorry, to be clear: all copy changes go through legal/Matej, and the final
> strings are what Paolo landed last week. If there were  changes, we would
> know about them

Thanks for clarifying.

Comment 17

[bbell]

Attachment: new_layout.png

Updated copy

Comment 18

[Marco Mucci [:MarcoM]]

Discussed with Paolo and marking this bug as resolved.  Paolo will file a follow up ENG bug for implementation.

Comment 19

[:Paolo Amadini]

Bryan, I have a question for you about the header on the right section, since strings in other languages may be significantly longer than English.

Instead of: "Tracking Protection ON"
Imagine you have: "Tracking Protection Feature ENABLED"

How would those fit in the mockup? Do we want them to be always on the same line, thus increasing the width of the section, or should we allow localizers to wrap the indicator and/or the words in the title?

A mockup for the enabled state with longer words would be appreciated!