1192899 - Consider wrapping preference titles

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

While we should strive to make the preference title strings as short as possible, sometimes this fails for l10n (e.g. bug 1181670) – we should consider wrapping the text.

Anthony, are you okay with this from a UX point of view? I'd like to make this mentorable.

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

This is going to happen too often (e.g. bug 1213999) so let's just do it.

Comment 3

[:Margaret Leibovic]

Let's try to do this as part of the settings reorganization.

Comment 4

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Not sure if we ended up doing this. Is there anything to do here?

Comment 5

[:Margaret Leibovic]

Mike, do you know what we need to change here? I can write (or review) a patch if it's simple.

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Margaret Leibovic from comment #5)
> Mike, do you know what we need to change here? I can write (or review) a
> patch if it's simple.

`android:ellipsize` typically handles this behavior but we're relying on the Preference classes, which automatically create this layout so we can't use this approach.

http://stackoverflow.com/q/15853773 appears to be a good answer.

The solution the submitter returned appears easy to break in future Android versions but is probably the simplest and safest. I'd opt for this one.

The next solution appears to complicate our preferences (e.g. we might override latest Android version's styles, more code means more places to break it, non-standard approach costs developer time) and bloat the APK a bit.

Switching to the AppCompat lib's preferences (bug 1205124) may also make this easier or fix it entirely, but that is a lot more complicated than just extending AppCompatActivity.

Margaret, do you want to take this or should I?

Comment 7

[:Margaret Leibovic]

This sounds like a PITA if we need to do this for each kind of Preference view we use.

It looks like this singleLine attribute is set to true even in Android 6.0, so I doubt using the compat library would help fix this:
http://androidxref.com/6.0.0_r1/xref/frameworks/base/core/res/res/layout/preference.xml#47

Thanks for investigating, but I think we should just WONTFIX this, and instead make sure we choose concise preference titles in our settings UI.

Comment 8

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to :Margaret Leibovic from comment #7)
> Thanks for investigating, but I think we should just WONTFIX this, and
> instead make sure we choose concise preference titles in our settings UI.

Is there any reliable way to indicate this to l10n? Should we add it to the localization comments of the title strings?

Comment 9

[:Margaret Leibovic]

(In reply to Michael Comella (:mcomella) from comment #8)
> (In reply to :Margaret Leibovic from comment #7)
> > Thanks for investigating, but I think we should just WONTFIX this, and
> > instead make sure we choose concise preference titles in our settings UI.
> 
> Is there any reliable way to indicate this to l10n? Should we add it to the
> localization comments of the title strings?

Sure, we can file a bug about updating that. Localizers do test how these strings appear in the UI, but it would be good to keep them informed of screen sizes we need to consider.