1193158 - Create a basic Site Permissions subview

Status: RESOLVED FIXED

(Firefox :: Address Bar, enhancement, P1)

Description

[Matthew N. [:MattN]]

To get the foundation for the Site Permissions subview we can create it with the headings specified in bug 1188356 for the existing permissions but exclude plug-ins (maybe providing a link to the Page Info tab for now) since they need extra work. This subview should use SitePermissions.jsm for population of data.

This bug is just for the foundation so follow-ups will handle other key elements:
* Adding plug-ins is bug 1193152
* Indicating non-default values is bug 1193154
* Handling of global permission overrides is bug 1193157

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: MozReview Request: Bug 1193158 - Create a basic site permissions subview;r=ttaubert

Bug 1193158 - Create a basic site permissions subview;r=ttaubert

Comment 2

[Dão Gottwald [:dao]]

> #identity-popup-permission-list menulist,
> #identity-popup-permission-subview-list menulist {
>   max-width: 100px;
> }

Please use a class for these menulists. Also, em is preferable over px here.

Comment 3

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8654403 [details]
MozReview Request: Bug 1193158 - Create a basic site permissions subview;r=ttaubert

https://reviewboard.mozilla.org/r/17681/#review15971

LGTM.

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/f460ad2878d9

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f460ad2878d9

Comment 6

[Paul Silaghi, QA [:pauly]]

43.0a1 (2015-09-01) Win 7
The only permission I see in the panel is for pop-ups. Is it ok for now, or should I see other permissions like geolocation, remember passwords etc, as in bug 885366 ?

Comment 7

[Brian Grinstead [:bgrins]]

(In reply to Paul Silaghi, QA [:pauly] from comment #6)
> 43.0a1 (2015-09-01) Win 7
> The only permission I see in the panel is for pop-ups. Is it ok for now, or
> should I see other permissions like geolocation, remember passwords etc, as
> in bug 885366 ?

The only permission you will see in the 'main' panel is anything that's been set as non-default for that site.  When you click the arrow and go into the subview you should see a listing of all permissions.

Comment 8

[Paul Silaghi, QA [:pauly]]

qe- since the permissions subpanel is going to be removed (bug 1203280)