Closed Bug 1203280 Opened 4 years ago Closed 4 years ago

Revert site permission subpanel changes

Categories

(Firefox :: General, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 43
Iteration:
43.3 - Sep 21
Tracking Status
firefox43 --- verified

People

(Reporter: bgrins, Assigned: bgrins)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy])

Attachments

(2 files)

The sub panel for site permissions isn't part of the designs anymore, so UI changes to that should be reverted.

Note that we should keep test coverage added in those bugs 1193158 and 1199790.
Flags: qe-verify+
Flags: firefox-backlog?
Flags: firefox-backlog?
Bug 1203280 - Back out all non-test changes from changeset 064a1ae9f3d4 (bug 1199790);r=MattN
Attachment #8658893 - Flags: review?(MattN+bmo)
Bug 1203280 - Back out all non-test changes from changeset f460ad2878d9 (bug 1193158);r=MattN
Attachment #8658894 - Flags: review?(MattN+bmo)
Just generated these by qbackout for these two revisions:

https://hg.mozilla.org/mozilla-central/rev/064a1ae9f3d4
https://hg.mozilla.org/mozilla-central/rev/f460ad2878d9

And then qref -X for the test manifest files and test files, updating the tests to remove any subview-specific checks
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Iteration: --- → 43.3 - Sep 21
Priority: -- → P1
Whiteboard: [fxprivacy][triage] → [fxprivacy]
Comment on attachment 8658893 [details]
MozReview Request: Bug 1203280 - Back out all non-test changes from changeset 064a1ae9f3d4 (bug 1199790);r=MattN

https://reviewboard.mozilla.org/r/18717/#review16741
Attachment #8658893 - Flags: review?(MattN+bmo) → review+
Comment on attachment 8658894 [details]
MozReview Request: Bug 1203280 - Back out all non-test changes from changeset f460ad2878d9 (bug 1193158);r=MattN

https://reviewboard.mozilla.org/r/18719/#review16743
Attachment #8658894 - Flags: review?(MattN+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/017ff4f3fea0
https://hg.mozilla.org/mozilla-central/rev/a92f1dd74ec0
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 43
QA Contact: paul.silaghi
(In reply to Brian Grinstead [:bgrins] from comment #0)
> The sub panel for site permissions isn't part of the designs anymore, so UI
> changes to that should be reverted.

Not that I disagree with the decision, but out of curiosity and also for the record, what was the reason for that change?
(In reply to Dão Gottwald [:dao] from comment #9)
> (In reply to Brian Grinstead [:bgrins] from comment #0)
> > The sub panel for site permissions isn't part of the designs anymore, so UI
> > changes to that should be reverted.
> 
> Not that I disagree with the decision, but out of curiosity and also for the
> record, what was the reason for that change?

I think to simplify the UI and only display non-default settings with an easy way to set them back to default.  Here's the updated designs: https://mozilla.invisionapp.com/share/DM3XGA6YE#/screens/100404627
Verified the permission subpanel is removed.
43.0a1 (2015-09-14) Win 7
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.