1193601 - Consider a different titlebar color for Windows 10

Status: RESOLVED FIXED

(Thunderbird :: Theme, enhancement)

Description

[Shawn Thompson]

User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:40.0) Gecko/20100101 Firefox/40.0
Build ID: 20150807085045

Steps to reproduce:

Firefox 40 contains some tweaks to the Australis interface style on Windows 10 (see bug 1158143) that should be adopted on Thunderbird as well.

Possibly, since it's been established that we can change the colors of the titlebar, we could also make it more of a Thunderbird blue than Firefox's gray titlebar.

Comment 1

[Richard Marti (:Paenglab)]

I'm doing the win 10 adaptions in bug 1188778. You can test them with the XPI I attached there. First I'm using a lighter gray than Firefox.

After landing we can use this bug here to consider if and what color we want to use.

Comment 2

[Richard Marti (:Paenglab)]

Attachment: TB-blue.png

This is a first shot how it could look with the Thunderbird blue.

Comment 3

[Richard Marti (:Paenglab)]

Attachment: TBcolorsWin10.png

Blake, what do you think about using the Thunderbird colors for the active window?

On top is Thunderbird light blue, in the middle is TB inactive and on bottom Thunderbird blue.

If we are using a color for the active window, which color would you prefer? Or would you have a different color in mind?

The inactive color is the one we are using now for both states.

Comment 4

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8660469 [details]
TBcolorsWin10.png

Since grey isn't really a Firefox colour, as much as the default colour for all the titlebars, and since the dark blue looks a little too eye-catching for something that isn't that important, _and_ since the white text is a little had to read on the light blue, I think I would pick the grey out of those three.

Having said that, I could probably be convinced to go with something close to the grey, but with a hint of the light blue in it.  Maybe somewhere near the experimentally-chosen #A8C6D4?  (Feel free to play around with that and come up with something better, though!  ;D  )

Comment 5

[Richard Marti (:Paenglab)]

Attachment: newProposal.png

(In reply to Blake Winton (:bwinton) (:☕️) from comment #4)
> Having said that, I could probably be convinced to go with something close
> to the grey, but with a hint of the light blue in it.  Maybe somewhere near
> the experimentally-chosen #A8C6D4?  (Feel free to play around with that and
> come up with something better, though!  ;D  )

For me this color looked a bit dirty. I tried it now with the TB light blue made lighter (#A8CBDB). What do you think about this? On top is the active window, on bottom the inactive.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8662270 [details]
newProposal.png

Perfect!  :D

Comment 7

[Richard Marti (:Paenglab)]

Attachment: activeColor.patch

Okay, patch with this color. Tested with LW-themes too. Needs no :not(:-moz-lwtheme) pseudoelement because LW-themes are overriding it through direct styling.

Comment 8

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Comment on attachment 8662438 [details] [diff] [review]
activeColor.patch

Review of attachment 8662438 [details] [diff] [review]:
-----------------------------------------------------------------

Code lgtm, r=philipp

Comment 9

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/e9fe39e33a27ca7274180dd570c74b79162d35b2
Bug 1193601 - [Windows 10] Use Thunderbird blue when window is active. ui-r=bwinton, r=Fallen a=aleth