1193636 - Use HTTPS for Yahoo! Japan search provider

Status: RESOLVED FIXED

(Mozilla Localizations :: ja / Japanese, defect)

Description

[Makoto Kato [:m_kato]]

Yahoo! Japan will provide HTTPS search page after 18 August.  (Now, it is still HTTP only yet)

http://promo.search.yahoo.co.jp/news/service/SSL.html

So could we change to HTTPS for Yahoo! Japan's search provider?

Comment 1

[Francesco Lodolo [:flod]]

I'd say it's a dupe of bug 997215.

Comment 2

[Makoto Kato [:m_kato]]

(In reply to Francesco Lodolo [:flod] from comment #1)
> I'd say it's a dupe of bug 997215.

Yahoo Japan is NOT Yahoo!'s company.  It is Softbank (owner of Sprint).  Also, we don't use suggestion etc by Y! Japan.

Comment 3

[Francesco Lodolo [:flod]]

(In reply to Makoto Kato [:m_kato] from comment #2)
> Yahoo Japan is NOT Yahoo!'s company.  It is Softbank (owner of Sprint). 

I don't understand what that changes. We need to update Yahoo searchplugins for ja and ja-JP-mac, and that request was originally done in bug 997215.

Also note that this is not the only issue we have with Yahoo searchplugins for Japanese: we'd need to update icons on desktop (16+32px), and mobile (bug 1179109), since the branding is still the old non-purple one.

Comment 4

[Makoto Kato [:m_kato]]

(In reply to Francesco Lodolo [:flod] from comment #3)
>
> Also note that this is not the only issue we have with Yahoo searchplugins
> for Japanese: we'd need to update icons on desktop (16+32px), and mobile
> (bug 1179109), since the branding is still the old non-purple one.

Incorrect.  The purple icon is Yahoo! US and their branches.  But Yahoo! Japan isn't

Current Yahoo! Japan logo is http://k.yimg.jp/images/top/sp2/cmn/logo-ns-131205.png.  Because Yahoo! Japan is Softbank's company and Yahoo! US is licensing logo and brand name to Softbank.

Comment 5

[Francesco Lodolo [:flod]]

I suggest to re-read my previous comment.

(In reply to Francesco Lodolo [:flod] from comment #3)
> since the branding is still the old non-purple one.

Let me rephrase it: since Yahoo! in Japan still uses the old branding (red Y! on white background), not the new purple one, we need a 96px icon for Fennec. Also, white background won't work it.

I checked and realized that I already fixed the icon on desktop, embedding both 16px and 32px
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/4a4a60f00204

Comment 6

[Makoto Kato [:m_kato]]

(In reply to Francesco Lodolo [:flod] from comment #5)
> I suggest to re-read my previous comment.
> 
> (In reply to Francesco Lodolo [:flod] from comment #3)
> > since the branding is still the old non-purple one.
> 
> Let me rephrase it: since Yahoo! in Japan still uses the old branding (red
> Y! on white background), not the new purple one, we need a 96px icon for
> Fennec. Also, white background won't work it.
> 
> I checked and realized that I already fixed the icon on desktop, embedding
> both 16px and 32px
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/ja/rev/4a4a60f00204

But current Yahoo! Japan logo into Firefox search box is old.  See bug 1119706.

Comment 7

[Francesco Lodolo [:flod]]

(In reply to Makoto Kato [:m_kato] from comment #6)
> But current Yahoo! Japan logo into Firefox search box is old.  See bug
> 1119706.

Thanks, I missed that bug.

Comment 9

[Makoto Kato [:m_kato]]

(ASAI-san won't read bugzilla mail :-<, but I believe he is biz owner of this issue)

Comment 10

[Masatoshi Kimura [:emk]]

I was very disappointed when I filed (In reply to Makoto Kato [:m_kato] from comment #9)
> (ASAI-san won't read bugzilla mail :-<, but I believe he is biz owner of
> this issue)

Where is the contact, then?

If external contributors have no official contact at the moment, Mozilla Japan should either
1. publish an official contact,
2. change the owner to someone that read bugmail, or
3. have the current owner read bugmail.

Comment 11

[Makoto Kato [:m_kato]]

(In reply to Masatoshi Kimura [:emk] from comment #10)
> I was very disappointed when I filed (In reply to Makoto Kato [:m_kato] from
> comment #9)
> > (ASAI-san won't read bugzilla mail :-<, but I believe he is biz owner of
> > this issue)
> 
> Where is the contact, then?

I don't know.  If I know it, I will contact to him about this before filing this bug.  As long as I knew, he had a meeting with Yahoo Japan last year.  As long as I talked with him 2 years ago about this, he didn't still handle this...

Comment 12

[Noriatsu Kudo]

I introduced a Yahoo!Japan person to Asai san, and held a meeting last August.
I was there for different agenda, so I am not in charge of this, but I have a meeting log.

From their answer, 
 - Search: we can change to HTTPS when we are ready after August 21th 2016.(No change in parameters)
 - Auction: Please wait until end of March 2017.(Changes in parameters are not decided.)

Therefore, we can just change to HTTPS for regular search. Also it is good chance to contact Yahoo!Japan again about Yahoo! Auction.

Comment 13

[Makoto Kato [:m_kato]]

Good news.

Kudo-san, we should update yahoo auction's icon design (bug 1278189) since they use 'ヤフオク' icon (background color is yellow) now.  Could you get current icon design of Yahoo Auction?

And, we don't update mobile icon of Yahoo Japan search yet. (bug 1259461).  So we need update status whether we can use high res icon.

Comment 14

[Makoto Kato [:m_kato]]

Francesco, could you change yahoo-jp.xml to HTTPS per comment #12?

Comment 15

[dynamis (Tomoya ASAI)]

Attachment: Patch1: use HTTPS for Yahoo! Japan for fennec (for ja/ja-JP-mac l10n repo)

This is the patch to update Yahoo! search for Fennec in l10n (ja/ja-JP-mac) repo.
I'll add another patch to update search for Desktop in mozilla-central repo.

Comment 16

[dynamis (Tomoya ASAI)]

Attachment: Patch1: use HTTPS for Yahoo! Japan for Firefox (for mozilla-central repo)

This is the patch to update Yahoo! search for Desktop Firefox in mozilla-central repo.
Please check and commit to mozilla-central repo.

Comment 17

[dynamis (Tomoya ASAI)]

Attachment: Patch3: use HTTPS for Yahoo! Japan for iOS Firefox (for firefox-ios repo)

This is the patch to update Yahoo! search for ios Firefox in firefox-ios repo.
Please review and commit to firefox-ios github repo.

search engine file:
https://github.com/mozilla-mobile/firefox-ios/blob/master/Client/Assets/Search/SearchPlugins/ja/yahoo-jp.xml

# sorry, previous patch was "patch2", not 2nd version of "patch1"

Comment 18

[Francesco Lodolo [:flod]]

Comment on attachment 8853302 [details] [diff] [review]
Patch3: use HTTPS for Yahoo! Japan for iOS Firefox (for firefox-ios repo)

Review of attachment 8853302 [details] [diff] [review]:
-----------------------------------------------------------------

We don't make direct changes to iOS, they're take from the mobile repository via script, and destined to change soon

Comment 19

[Francesco Lodolo [:flod]]

Comment on attachment 8853291 [details] [diff] [review]
Patch1: use HTTPS for Yahoo! Japan for Firefox (for mozilla-central repo)

Review of attachment 8853291 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look sane, but I'd prefer Mike to stamp them, since this is a partner.

Comment 20

[Mike Kaply [:mkaply]]

As stated, iOS is unnecessary right now.

Fennec patch should wait and go in after bug 1324045 into central.

Comment 21

[Francesco Lodolo [:flod]]

(In reply to Mike Kaply [:mkaply] from comment #20)
> Fennec patch should wait and go in after bug 1324045 into central.

I think that we can land this in mozilla-aurora, I'll file a follow-up bug and assign it to myself to keep track of these changes after bug 1324045 lands.

Comment 22

[Francesco Lodolo [:flod]]

Comment on attachment 8853289 [details] [diff] [review]
Patch1: use HTTPS for Yahoo! Japan for fennec (for ja/ja-JP-mac l10n repo)

I'm going to take care of this in bug 1352450, so we can land the desktop stuff and close this bug.

Comment 23

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/dcade1e36862
"Use HTTPS for Yahoo! Japan search provider" r=mkaply

Comment 24

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dcade1e36862