1193764 - Direct calls hang if the contact hasn't connected to the server at all

Status: VERIFIED FIXED

(Hello (Loop) :: Client, defect, P1)

Description

[Mark Banner (:standard8)]

STR

1) Start up a browser and sign-into FxA via Hello
2) Create a contact to an email address that should never have tried to connect to the system
3) Start a direct call to that contact

Actual Results

=> The conversation window appears and stays at "Connecting..."

Expected Results

=> The conversation window appears, shows "Connecting..." for a while, and then shows "user unavailable" (or whatever we should show).

Comment 1

[Mark Banner (:standard8)]

Attachment: Loop's Direct calls hang if the contact hasn't connected to the server at all.

The basic issue here is that we're trying to squeeze a number into a string which the action validator doesn't like, and so nothing the connection failure isn't being handled.

I've done some changes to use the failure details rather than the rest errnos - so one less place that's being used in the UI. Also included is extra test coverage to make sure we cover that branch.

Comment 2

[Dan Mosedale (:dmosedale, :dmose)]

Interestingly, the failure mode I see without this patch is not "user unavailable", but "there was a problem" (approximate german translation :-).

Comment 3

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 8647013 [details] [diff] [review]
Loop's Direct calls hang if the contact hasn't connected to the server at all.

Review of attachment 8647013 [details] [diff] [review]:
-----------------------------------------------------------------

r=dmose

Comment 4

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/5c3a49360f3b

Comment 5

[Mark Banner (:standard8)]

This was a regression from bug 1120003.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 8647013 [details] [diff] [review]
Loop's Direct calls hang if the contact hasn't connected to the server at all.

Approval Request Comment
[Feature/regressing bug #]: Bug 1120003
[User impact if declined]: When attempting a direct call, in some circumstances the window may stop at "Connecting" and not report that the callee is unavailable.
[Describe test coverage new/current, TreeHerder]: Includes increased unit test coverage to handle this case.
[Risks and why]: Low, simple small fix to handle the failure reason properly
[String/UUID change made/needed]: None

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5c3a49360f3b

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8647013 [details] [diff] [review]
Loop's Direct calls hang if the contact hasn't connected to the server at all.

Patch has been in Nightly for a few days, seems safe to uplift to Aurora and Beta.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/af2e137813b6

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/e259ef0a5197

Comment 11

[Bogdan Maris, Desktop QA]

Reproduced the initial issue using old Nightly from 2015-08-12, verified that the issue is fixed using Firefox 41 beta 3, latest Developer Edition 42.0a2 and latest Nightly 43.0a1 across platforms (Windows 7 64-bit, Ubuntu 14.04 32-bit and Mac OS X 10.10.4).