1193839 - https://www.mozilla.org/en-US/firefox/nightly/firstrun/ uses Firefox favicon instead of Nightly

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[alex_mayorga]

Steps:

Load https://www.mozilla.org/en-US/firefox/nightly/firstrun/

Result:

The favicon shown is https://mozorg.cdn.mozilla.net/media/img/firefox/favicon.dc6635050bf5.ico

Expected result:

The favicon shown is https://nightly.mozilla.org/img/favicon.png

See also:

https://bugzilla.mozilla.org/show_bug.cgi?id=682188
https://bugzilla.mozilla.org/show_bug.cgi?id=717322
https://bugzilla.mozilla.org/show_bug.cgi?id=841846

Comment 1

[Joseph]

Could I submit a pull request on github instead of attaching a file to this bug?

Comment 2

[Schalk Neethling [:espressive]]

That would work a treat Joseph, thanks!

Comment 3

[Joseph]

Do I just do a pull request or do I have to say here that I've done a pull request?

Comment 4

[Joseph]

Pull Request is here: https://github.com/mozilla/bedrock/pull/3223

Comment 5

[Joseph]

Jon Petto, I have done what you have said on the pull request.

Comment 6

[Joseph]

New pull request: https://github.com/mozilla/bedrock/pull/3229

Comment 7

[Joseph]

I've merged/squashed all the commits together now. https://github.com/mozilla/bedrock/pull/3229

Comment 8

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/9988cd8e735c2b8f94a8245295a4c3d57058aad2
# This is a combination of 2 commits.
# The first commit's message is:

[fix bug 1193839] Update favicon for /firefox/nightly/firstrun.

# The 2nd commit message will be skipped:

#	Update nightly_firstrun.html
#
#	[fix bug 1193839] Update favicon for /firefox/nightly/firstrun.
#
#	Changed favicon path to a local one.
#
#	[fix bug 1193839] Update favicon for /firefox/nightly/firstrun. Added favicon-nightly.png
#
#	[fix bug 1193839] Update favicon for /firefox/nightly/firstrun.

https://github.com/mozilla/bedrock/commit/99140ac91a93ebabf070bff59c10deca8ebabf1d
Merge pull request #3229 from TheJJ100100/bug-1193839-update-nightly-firstrun-favicon

Fix Bug 1193839, update nightly firstrun favicon