1194801 - Autophone not submitting results to Treeherder

Status: RESOLVED FIXED

(Testing Graveyard :: Autophone, defect, P1)

Description

[Bob Clary [:bc] (inactive)]

Autophone gets a build's revision from the corresponding txt file, e.g.:

http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mozilla-central/firefox-43.0a1.en-US.linux-i686.txt

which is now a 40 char revision. This causes Treeherder's resultset api to fail to retrieve the result set:

https://treeherder.mozilla.org/api/project/mozilla-central/resultset/?revision=4e883591bb5dff021c108d3e30198a99547eed1e

I need to only use the first 12 characters in order to be able to pull up the revision hash for the build:

https://treeherder.mozilla.org/api/project/mozilla-central/resultset/?revision=4e883591bb5d

camd: maybe treeherder could just ignore everything past the 12 character revision.

Comment 1

[Michael Shal [:mshal]]

From :gps in https://bugzilla.mozilla.org/show_bug.cgi?id=1175655#c0, we should be using the 40 character revision everywhere. Would it be possible to use the 40 character rev here instead of truncating it to 12?

Comment 2

[Bob Clary [:bc] (inactive)]

camd: I'm going to switch to truncating the revision I submit to 12 characters. If we need to change Treeherder, lets do this compatibly. First allow both 12 and 40 characters, then announce the change and the need to update clients before we drop the 12 character support. Do you want to file the Treeherder bug?

Comment 3

[Bob Clary [:bc] (inactive)]

https://github.com/mozilla/autophone/commit/0ee96a97a82b67639a8df0ae35119ddb07511323

Comment 4

[Cameron Dawson [:camd]]

Hey Bob-- Sure thing.  I entered bug 1194908 for this.  There are possibly more implications than just a one-line fix in the code of that endpoint -- aren't there always?  :)

What's your urgency on this?  Just trying to prioritize.

Comment 5

[Bob Clary [:bc] (inactive)]

camd: No urgency now. I have a work around where I trim the revision before submitting to the resultset api. My email alerts still have the full revision in their links to Treeherder but I rather than scatter this change around my code, I'll just manually edit those. This will of course break when Treeherder moves to the 40 char revision, so I'll have to revert the change when you deploy.