1194927 - Installing an add-on from website doesn't update an empty view in Add-ons Manager

Status: RESOLVED WONTFIX

(Toolkit :: Add-ons Manager, defect)

Description

[Carlos [nohamelin]]

Attachment: Add-ons Manager: installation of ABP appears to be incomplete or failed

* In a new profile, ensure than no extensions are installed at all, and left open the Add-ons Manager in the Extensions view (The "You don't have any add-ons of this type installed" message should be visible).
* Open a new tab, go to AMO and install any extension: Adblock plus, in this case.
* After completing the install process without problems, switch to the tab with the AM.

Expected results:
- See the ABP entry, listed as installed and enabled.

Actual results:
- An apparent broken entry for ABP is displayed (see attachment). Refreshing the page, or changing category and going back to Extensions fixes the view: the add-on was in fact installed correctly (note the ABP toolbar button in the image).

It's possible, with a bit of more work, trigger this issue with the Languages view for langpacks, but, oddly enough, it doesn't happen with the Services category.


This case was reproduced in Fx Nightly, Linux, but I was able to trigger this issue too (with langpacks, though) in Aurora, current Release (Fx 40), but not in current ESR (38.2.0), so I suspect strongly of it as a regression from the work for the new all-in-doorhanger install flow for add-ons landed in Fx 39 (bug 1139656).

The issue doesn't happen if the installation is via "Install extension from file" in the Add-ons Manager itself.

Comment 1

[Alice0775 White]

Pushlog:
https://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=380fcf2381b5&tochange=3b4fa5cc6210

Regressed by:
3b4fa5cc6210	Richard Marti — Bug 989469 - Use new style for add-on manager. ui-r=mmasalaney r=mossop CLOSED TREE

Comment 3

[Carlos [nohamelin]]

Triggering it is fairly easy for new users of my Simple Locale Switcher extension, but with languages packs instead. The add-on makes the (usually hidden) Languages pane visible by default, and it places there a button to get langpacks from some website (AMO or archive.mozilla.org). It can lead to see an apparently wrong installation of the first langpack picked, impacting the first-run experience with the add-on.

Comment 6

[Caitlin Neiman [:caitmuenster]]

If this is your first contribution, please see our onboarding guide: https://wiki.mozilla.org/WebExtensions/Contribution_Onramp

Comment 7

[Pankhuri Saxena]

Hello!

Can I give it a try to solve this bug?

I am new to Mozilla and trying to contribute for Outreachy 2019.

Comment 8

[Caitlin Neiman [:caitmuenster]]

Hey Pankhuri, welcome! This bug's all yours. :)

Just a quick heads up: the WebExtensions team doesn't have a project for Outreachy Summer 2019. If you could email me at [e-mail] and let me know which project(s) you are interested in, I can try to direct you to those project mentors.

Comment 9

[lekhikadugtal]

hey Caitlin, I wanted to ask Isn't new certificate viewer for Firefox is the project for outreachy 2019. And This is one of the bug firefox-frontend given on outreachy site.

Comment 10

[Caitlin Neiman [:caitmuenster]]

(In reply to lekhikadugtal from comment #9)

hey Caitlin, I wanted to ask Isn't new certificate viewer for Firefox is the project for outreachy 2019. And This is one of the bug firefox-frontend given on outreachy site.

Hey Lekhikadugtal! Yes, you are right -- I learned after I made comment #8 that the mentor of the new certificate viewer for Firefox project is encouraging applicants to contribute to any Firefox-frontend bug as part of the application process. :) So you are in the right place!

Comment 11

[afshan.shokath]

Hello Caitlin,
Can I be work on this bug? I am an outreachy applicant.

Comment 12

[Caitlin Neiman [:caitmuenster]]

(In reply to afshan.shokath from comment #11)

Hello Caitlin,
Can I be work on this bug? I am an outreachy applicant.

Let's just confirm that Pankhuri and lekhikadugtal aren't planning on working on it. :) Pankhuri & lekhidagtal, can you confirm?

Comment 13

[lekhikadugtal]

I'm working on different bug. Thanks for asking Caitlin :).

Comment 14

[Caitlin Neiman [:caitmuenster]]

Thank you, lekhikadugtal! I talked to Pankhuri offline and it looks like they are working on another project.

Afshan, this bug is all yours! \o/ The bug mentor is on PTO until March 11 so please needinfo me if you need any help and I'll help connect you with another mentor. :)

Comment 15

[afshan.shokath]

(In reply to Caitlin Neiman [:caitmuenster] from comment #14)

Thank you, lekhikadugtal! I talked to Pankhuri offline and it looks like they are working on another project.

Afshan, this bug is all yours! \o/ The bug mentor is on PTO until March 11 so please needinfo me if you need any help and I'll help connect you with another mentor. :)

Thank you so much. I will start working on it. Can you please change the status of this bug as assigned to me?

Comment 16

[afshan.shokath]

Hello Caitlin,
so apparently removing the add-on with 'remove' button from Extensions view doesn't update AM page automatically. Should I file this as a new bug?

Comment 17

[afshan.shokath]

Hey Andrew,
I am the one who is assigned to this bug and who had mailed you. I will communicate from here now onwards.
Like I said in the mail, I have been able to reproduce the bug and now I am looking at the source code.

Comment 18

[afshan.shokath]

So, this problem persists even when an add-on is installed from Add-ons->Get Add-ons not just when it is installed from website

Comment 19

[afshan.shokath]

The component it is supposed to render is the result of html's 'progress' tag when the attribute-value is status='installing' of the <html:progress> tag in the xul file.

When the class='progress' where progress being the css class is removed then it renders correctly.

How do I share images here?

Comment 20

[Caitlin Neiman [:caitmuenster]]

Hey Afshan, I am sorry for being so late getting back to you. We reviewed this issue and realized it's a wontfix. The code affected is the XUL version of about:addons, and we're currently in the process of rewriting it into HTML.

I know closing this bug affects your Outreachy application. :( I'd encourage you to pick up another front-end good-first-bug. Here's a list of them: https://codetribute.mozilla.org/projects/ff?tag%3Dgood-first-bug

Good luck with your application!

Comment 21

[afshan.shokath]

Hey,
I spent days working on it. The deadline is just 5 days away and I don't know what do now. This is seriously not OK for me since all-good bugs are taken already and I am new to contributing.

Comment 22

[Andrew Swan [:aswan]]

(In reply to afshan.shokath from comment #21)

I spent days working on it. The deadline is just 5 days away and I don't know what do now. This is seriously not OK for me since all-good bugs are taken already and I am new to contributing.

If you're close to having a working patch, we can still accept it. I just want to make it clear though, that the current xul implementation of about:addons (which is the code that a patch for this bug would affect) is slated for removal in Firefox 69. If that's okay with you, you can still get the experience of getting your patch reviewed, landed, etc. If you're not close to having a patch ready for this bug, I would recommend finding a new bug.

Comment 23

[Caitlin Neiman [:caitmuenster]]

To add to what aswan said, we've talked to the mentor for the project you're applying for and we can get you a good first bug.

Comment 24

[Johann Hofmann [:johannh]]

Hi Afshan, I just opened up bug 1537535, would you like to take that one? If so, please add a comment to the bug.

Thanks!

Comment 25

[afshan.shokath]

Yes. I have did thank you.

Comment 26

[afshan.shokath]

(In reply to Caitlin Neiman [:caitmuenster] from comment #23)

To add to what aswan said, we've talked to the mentor for the project you're applying for and we can get you a good first bug.
Thanks a lot.