Closed
Bug 1195129
Opened 10 years ago
Closed 10 years ago
Port |Bug 1027890 - Remove all sorts of build system code dedicated to pymake| and |Bug 1082323 - Reject pymake in client.mk| to comm-central
Categories
(MailNews Core :: Build Config, defect)
MailNews Core
Build Config
Tracking
(firefox43 affected)
RESOLVED
WONTFIX
| Tracking | Status | |
|---|---|---|
| firefox43 | --- | affected |
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
Details
Attachments
(1 file, 1 obsolete file)
|
2.33 KB,
patch
|
Details | Diff | Splinter Review |
pymake build system code was removed from mozilla-central in Bug 1027890, we should probably remove the similar code in commm-central
Attachment #8648509 -
Flags: review?(Pidgeot18)
Probably makes sense to port the follow-up bug too.
Summary: Port |Bug 1027890 - Remove all sorts of build system code dedicated to pymake| to comm-central → Port |Bug 1027890 - Remove all sorts of build system code dedicated to pymake| and |Bug 1082323 - Reject pymake in client.mk| to comm-central
This ports both changes.
Attachment #8648509 -
Attachment is obsolete: true
Attachment #8648509 -
Flags: review?(Pidgeot18)
Attachment #8648511 -
Flags: review?(Pidgeot18)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8648511 [details] [diff] [review]
Remove the code and reject pymake
Review of attachment 8648511 [details] [diff] [review]:
-----------------------------------------------------------------
I'm going to cancel all reviews involving client.mk. Within a few months, we're going to have to end up merging m-c and c-c one way or another, and the current comm-central client.mk will disappear at that point. Client.mk is very difficult to trust changes, since it sometimes has to support not having m-c present, so this is high risk and low value.
Attachment #8648511 -
Flags: review?(Pidgeot18)
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•