Closed Bug 1195268 Opened 10 years ago Closed 6 years ago

Screenshot navigation arrows are flicking when clicked

Categories

(Marketplace Graveyard :: Consumer Pages, defect, P3)

Product:
Marketplace Graveyard
Component:
Consumer Pages
Version:
Avenir
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
2015-08-18

People

(Reporter: madalin.cotetiu, Assigned: richarupela95, Mentored)

Details

(Whiteboard: [good first bug][lang=html])

Steps to reproduce: 1. Open detail page for an app with many screenshots (i.e: https://marketplace.allizom.org/app/connecta2) 2. Click on the screenshot navigation arrows. Expected results: The screenshots are changed correctly, there are no display issues. When the last screenshot is displayed the button is no longer click-able. Actual results: The arrow is flicking when clicked. When the last screenshot is displayed the button is still click-able. Notes/Issues: Verified in FF43(Win7) Issue can be reproduced in mp-stage. Screencast for this issue: http://screencast.com/t/PYVhu59sSD3
Mentor: trishul.goel
Whiteboard: [good first bug][lang=html]
Hello, i would like to fix this bug.
You have been assigned. Thanks, trishul will tell you how get started :)
Assignee: nobody → richarupela95
Status: NEW → ASSIGNED
Flags: needinfo?(trishul.goel)
Thanks Atique, @Rits, Bug 1007548 is already assigned to you, can you handle both simultaneously?If yes then please consider following. The flicker can be removed by adding `data-no-transparent` attribute to previous and next buttons. (These will be in src/media/js/previews-buttons.js)
Flags: needinfo?(trishul.goel)
Hello, Trishul i was facing some issues with the previously assigned bug, i will work on both of them surely. Thank you for the pointers.
Severity: normal → minor
Priority: -- → P3
Created a Pull Request: https://github.com/mozilla/fireplace/pull/1458
@rits This is on a hold for a while, you may work on other bug.
Kevin -- can you update this with what you're looking into?
Flags: needinfo?(kngo)
I'm not seeing this at the moment, and I also have https://github.com/mozilla/fireplace/pull/1474 open which https://github.com/mozilla/fireplace/pull/1458 may depend on. So let's wait on getting https://github.com/mozilla/fireplace/pull/1474 in first.
Flags: needinfo?(kngo)
Kevin, 1474 is still open. Is that waiting for anything in particular?
Flags: needinfo?(kngo)
This issue is reproducing in MP-prod using FF45(Win 7). Screencast: http://screencast.com/t/IopF9Z67nlG1
Hi Kevin, Any updates on this?
Hello Trishul, I have recently started contributing to Market Place and would like to work on this bug if it is not yet resolved. Thank you.
I think this issue has been resolved in both dev and production, ValentinaP can you please confirm?
Flags: needinfo?(valentina.peleskei)
Unfortunately, no. Please see the screencast using FF46(Win 7): http://screencast.com/t/2BwHrrB5Oi2
Flags: needinfo?(valentina.peleskei)
As per comment 0 , I think the bug is- When arrow becomes disabled or when there is no more screenshots in either side, the arrow is still click-able & flicking in disabled state. And this situation is still reproducible. So, a fix might be: To make the arrow not flicking anymore when the arrow becomes disable.
I'd like to work on this bug, could someone help me. Please
Flags: needinfo?(kngo)
Hello everyone! I would like to work on this bug in case no one is working on this. Can someone please guide me on how to proceed? Thanks in advance!
Firefox Marketplace has been shut down since March. Closing remaining bugs.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.