1195285 - Shumway's bootstrap-content.js sends a sync message to the parent process periodically within the same process

Status: RESOLVED FIXED

(Firefox Graveyard :: Shumway, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Here are some profiles:

http://people.mozilla.org/~bgirard/cleopatra/#report=48152b29cb5d69ce48546326cd96d55b92b241af&filter=%5B%7B%22type%22%3A%22RangeSampleFilter%22,%22start%22%3A3394296,%22end%22%3A3394941%7D%5D&selection=0,5575,5576,5577,5578,5291,5579,8,9,10,11,12,13,14,15,16,17,20,21,22,23,24,25,26,726,727,728,729,730,731,5621,6793,6374,6794,1497,1498,1499,80,6812,6813,6814,81,113,79,106,107,108,78,79,134,135,168,6815,5778,6816,6817,6818,4289,4290,4167,4168

http://people.mozilla.org/~bgirard/cleopatra/#report=ece3a7204fbac86bfa487b80f7a15d38389f9f65&search=shumway&selection=0,4085,4086,4087,4088,3848,4089,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,733,734,735,736,737,738,4092,4243,4094,4244,4272,4273,4274,34,4302,4303,4304,35,36,33,37,38,39,32,33,51,52,53,4305,4194,4306,4307,4308,1043,1044,1045,1046

If you filter for shumway, you'll see that there are some instances where bootstrap-content.js sends a sync message up to the parent process:

https://dxr.mozilla.org/mozilla-central/rev/0876695d1abdeb363a780bda8b6cc84f20ba51c9/browser/extensions/shumway/chrome/bootstrap-content.js?offset=300#57

Note that this is with dom.ipc.processCount == 1. So it seems strange that we would attempt to query and re-register for the same content process. I suspect this is similar to bug 1186448 where we only want to register once per content process.

Comment 1

[Till Schneidereit [:till]]

Yury, can you take a look at this?

Comment 2

[Yury Delendik (:yury)]

Attachment: Register bootstrap-content.js once per child process.

(In reply to Mike Conley (:mconley) - Needinfo me! from comment #0)
> I suspect this is similar to bug 1186448 where we only want to register once
> per content process.

That's correct. Shumway and PDF Viewer's e10s code are really similar. Submitting patch similar to bug 1186448 (selecting reviewer based on this bug's patch).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=496dc32a0ab7

Comment 3

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/34cb31a62883

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/integration/fx-team/rev/34cb31a62883

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/34cb31a62883