Closed Bug 1195287 Opened 4 years ago Closed 4 years ago
Wrong colors in text selection toolbar
The text color in the text selection toolbar is wrong (long pressing text in the url bar). See attached screenshot. Could be a regression introduced in bug 1164287.
Note: This only affects text selection in the URL bar. Selecting text on the website shows a different text selection bar closer to the content. This is definitely happening because we switched our base theme to Theme.Material.Light.DarkActionBar on v21+. I see two options: 1) We could switch the text selection bar to a dark action bar. This works and looks kinda cool but our icons are dark gray for a light action bar and this looks just wrong. I attached a screenshot of this. 2) Modify the theme to get a light text selection bar with the correct text color. I haven't found a way to do that yet. The 'Material/Marshmallow' way would be to use a "floating toolbar": http://www.androidpolice.com/2015/06/03/android-m-feature-spotlight-faster-text-selection-and-a-floating-toolbar-for-text-actions/
Bug 1195287 - Fix wrong colors in text selection toolbar on v21+. r?mhaigh This patch creates a copy of the GeckoAppBase style in v21/themes.xml and removes the custom icons for copy, cut and paste we use on v11+. Instead the system icons, that match the look&feel of the ActionBar, will be used.
Attachment #8654114 - Flags: review?(mhaigh)
Comment on attachment 8654114 [details] MozReview Request: Bug 1195287 - Fix wrong colors in text selection toolbar on v21+. r?mhaigh https://reviewboard.mozilla.org/r/17617/#review15985
Attachment #8654114 - Flags: review?(mhaigh) → review+
You need to log in before you can comment on or make changes to this bug.